From b72de018132acaae77ebc3852ed369cf45edc8fb Mon Sep 17 00:00:00 2001
From: Katrin Fischer <katrin.fischer.83@web.de>
Date: Mon, 19 Oct 2020 00:38:31 +0000
Subject: [PATCH] Bug 25897: Use cn_sort for sorting callnumbers in inventory
 table

Instead of using the machine sortable form of the callnumber from
cn_sort the table was only sorting on the callnumber. This tries
to fix it using the same technique as for sorting the differently
formatted dates.

To test:
- If your database has items with suitably cataloged items, use
  these. Otherwise you could use the examples from the bug report:

- Catalog items with the following barcodes:
   B 29 V55 1998
   B29 .C55 2008
   B29 .L24 1983
   B29 .L264 1998
   B29 .P666 2004
  Make sure the LOC is selected in $2 as source of classification
  This makes sure the sortable form of the callnumber is calculated
  correctly.
- Go to inventory
- Search for your items
- Before patch, they should sort on callnumber as above, after the
  patch the correct sort order should be:
   B29 .C55 2008
   B29 .L24 1983
   B29 .L264 1998
   B29 .P666 2004
   B 29 V55 1998

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt
index 0c15f41578..82df1cf3df 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt
@@ -193,7 +193,7 @@
         <tr>
             [% UNLESS uploadedbarcodesflag %]<th>Seen</th>[% END %]
             <th>Barcode</th>
-            <th>Call number</th>
+            <th class="title-string">Call number</th>
             <th>Library</th>
             <th class="anti-the">Title</th>
             <th>Not for loan</th>
@@ -215,7 +215,9 @@
             <td>
             [% result.barcode | html %]
             </td>
-            <td>[% result.itemcallnumber | html %]</td>
+            <td>
+                <span title="[% result.cn_sort %]">[% result.itemcallnumber | html %]</span>
+            </td>
             <td>
                 [% Branches.GetName( result.homebranch ) | html %]
                 <span class="shelvingloc">[% result.location | html %]</span>
-- 
2.39.5