From bc9a37534f10a13ca9513fae31d094e322e5358b Mon Sep 17 00:00:00 2001 From: George Veranis Date: Wed, 8 Feb 2023 13:21:39 +0100 Subject: [PATCH] Bug 32908: Load item type icons from the correct path MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit In the Staff interface, the details page of a bibliographic record should display the icon associated with the item type of an item ('Item type' column in the 'Holdings' tab). This feature broke in v22.11.00 (for Debian package installs): instead of the item type icon you get the default 'broken image URL' image of your web browser. This patch fixes that. Test plan: 1) (if needed) Configure the following System preferences: - item-level_itypes => 'specific item' - noItemTypeImages => 'Show' 2) (if needed) In Koha Administration > Item types, create an item type and associate it with an icon 3) (if needed) Create a test bibliographic record, and add an item to it that has an item type with an icon 4) Visit the bibliographic record's details page in the Staff interface. Notice that in the 'Item type' column of the 'Holdings' tab instead of seeing the icon associated with the item type of each item you get the default 'broken image URL' image of your web browser [*]. [*] In non-Debian package installs, the 'href' property of the item type icon's tag should start with '/opac-tmpl/bootstrap/itemtypeimg' 5) Apply this patch, and refresh the page with CTRL-F5. The item type icon should now be displayed correctly. [*] KTD and Koha Sandboxes users: To verify the patch has worked, you should right-click on the item type icon and click 'Inspect: the 'href' property of the tag should now start with: '/intranet-tmpl/prog/img/itemtypeimg' Signed-off-by: Frédéric Demians Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi --- koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt index 58ca8e1a70..a5dc67707f 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ -405,8 +405,8 @@ [% IF ( item_level_itypes ) %] [% SET itemtype = item.itemtype %] - [% IF !noItemTypeImages && itemtype.image_location %] - [% itemtype.translated_description | html %] + [% IF !noItemTypeImages && itemtype.image_location('intranet') %] + [% itemtype.translated_description | html %] [% END %] [% itemtype.translated_description | html %] -- 2.39.5