From ce479d7a7d0b3fac21994662592690fad83dab0e Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Mon, 14 Oct 2019 16:36:34 +0100 Subject: [PATCH] Bug 23805: Update 'lost_item_return' to 'LOST_RETURN' for consistency Signed-off-by: Kyle Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize --- C4/Circulation.pm | 2 +- Koha/Account.pm | 6 +++--- api/v1/swagger/definitions/patron_account_credit.json | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 86443edb15..3aa5ff6b2e 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -2454,7 +2454,7 @@ sub _FixAccountForLostAndReturned { $credit = $account->add_credit( { amount => $credit_total, description => 'Item Returned ' . $item_id, - type => 'lost_item_return', + type => 'LOST_RETURN', interface => C4::Context->interface, library_id => $branchcode } diff --git a/Koha/Account.pm b/Koha/Account.pm index f93ec494d9..d7d18457bc 100644 --- a/Koha/Account.pm +++ b/Koha/Account.pm @@ -325,7 +325,7 @@ $credit_type can be any of: - 'CREDIT' - 'payment' - 'FORGIVEN' - - 'lost_item_return' + - 'LOST_RETURN' - 'writeoff' =cut @@ -718,7 +718,7 @@ sub reconcile_balance { our $offset_type = { 'CREDIT' => 'Manual Credit', 'FORGIVEN' => 'Writeoff', - 'lost_item_return' => 'Lost Item', + 'LOST_RETURN' => 'Lost Item', 'payment' => 'Payment', 'writeoff' => 'Writeoff', 'ACCOUNT' => 'Account Fee', @@ -741,7 +741,7 @@ our $offset_type = { our $account_type_credit = { 'CREDIT' => 'CREDIT', 'FORGIVEN' => 'FORGIVEN', - 'lost_item_return' => 'LOST_RETURN', + 'LOST_RETURN' => 'LOST_RETURN', 'payment' => 'Pay', 'writeoff' => 'W' }; diff --git a/api/v1/swagger/definitions/patron_account_credit.json b/api/v1/swagger/definitions/patron_account_credit.json index 6b0889b168..9f00f26eda 100644 --- a/api/v1/swagger/definitions/patron_account_credit.json +++ b/api/v1/swagger/definitions/patron_account_credit.json @@ -3,7 +3,7 @@ "properties": { "credit_type": { "type": "string", - "description": "Type of credit ('CREDIT', 'FORGIVEN', 'lost_item_return', 'payment', 'writeoff' )" + "description": "Type of credit ('CREDIT', 'FORGIVEN', 'LOST_RETURN', 'payment', 'writeoff' )" }, "amount": { "type": "number", -- 2.39.5