From d31ee5980b2a52db6d1c60d9dd744f4584df3e40 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Thu, 6 Feb 2020 11:10:39 -0300 Subject: [PATCH] Bug 24602: Make get_onshelfholds_policy fallback to 0 The onshelfholds circulation rules values are more of an ENUM type (as opposed to other rules with integers like max*qty). In the quantities cases, it makes sense to have undef mean unlimited. In the enum type it is clearer to just set a default value (0) as the code already expects (Note: undef and 0 both eval to false so there's no behaviour problem, but warnings or we get forced to check for defined when the rule is used. It seems trivial to just make the rule fallback to a chosen default value). This patch makes it fallback to 0. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/CirculationRules.t \ t/db_dependent/Reserves.t => FAIL: CirculationRules.t fails and Reserves.t prints a warning 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests pass! No warning! 4. Sign off :-D Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize --- Koha/CirculationRules.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Koha/CirculationRules.pm b/Koha/CirculationRules.pm index c26f572d12..6c36ba3b40 100644 --- a/Koha/CirculationRules.pm +++ b/Koha/CirculationRules.pm @@ -420,7 +420,7 @@ sub get_onshelfholds_policy { rule_name => 'onshelfholds', } ); - return $rule ? $rule->rule_value : undef; + return $rule ? $rule->rule_value : 0; } =head3 article_requestable_rules -- 2.39.5