From da2886132e8445dd472b8b9ccd67e07365657c3a Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Thu, 29 Mar 2018 10:45:30 -0300 Subject: [PATCH] Bug 20428: Make about.pl inform about missing upload_tmp_path entry This patch makes about.pl warn about a missing upload_tmp_path entry in koha-conf.xml. It also mentions the effectively used tmp dir. Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart --- about.pl | 8 ++++++++ koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 8 ++++++++ 2 files changed, 16 insertions(+) diff --git a/about.pl b/about.pl index b3cad66325..6fdb5785e6 100755 --- a/about.pl +++ b/about.pl @@ -46,6 +46,7 @@ use Koha::Caches; use Koha::Config::SysPrefs; use Koha::Illrequest::Config; use Koha::SearchEngine::Elasticsearch; +use Koha::UploadedFiles; use C4::Members::Statistics; @@ -260,6 +261,13 @@ if ( ! defined C4::Context->config('upload_path') ) { } } +if ( ! defined C4::Context->config('upload_tmp_path') ) { + push @xml_config_warnings, { + error => 'uploadtmppath_entry_missing', + effective_upload_tmp_dir => Koha::UploadedFile->temporary_directory + } +} + # Test QueryParser configuration sanity if ( C4::Context->preference( 'UseQueryParser' ) ) { # Get the QueryParser configuration file name diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt index abcd8c3587..0e462b66e5 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt @@ -414,6 +414,14 @@ Also note that you need to properly set the OPACBaseURL preference for the file upload plugin to work. + [% ELSIF config_entry.error == 'uploadtmppath_entry_missing' %] + + Warning + You are missing the <upload_tmp_path> entry in your koha-conf.xml file. Please + add it, pointing to the configured temporary file upload directory for your Koha instance. + The effective temporary file upload directory is '[% config_entry.effective_upload_tmp_dir %]' + + [% END %] [% END %] -- 2.39.5