From f340e17a5e8618d95f6016f874a74217ae5c909f Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Fri, 6 Aug 2021 12:54:46 +0000
Subject: [PATCH] Bug 7703: (follow-up) Treat no items like none available

This patch modifies the holds template so that during the
multi-hold process, titles with no items attached are treated the same
way as titles with no items available (items exist but cannot be place
don hold):

 - The row showing such a record will say "No items are available to be
    placed on hold."
 - The pickup location dropdown will be hidden.

To test, follow the previous test plan and confirm that these change are
reflected. Now that the pickup location field isn't present for titles
without items you should be able to complete the holds process.

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
---
 .../prog/en/modules/reserve/request.tt             | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
index 2e5fbeaf1c..f54ac0d32a 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
@@ -305,7 +305,7 @@
                                             [% IF ( biblioloo.alreadyres ) %]
                                                 <ul>
                                             [% ELSE %]
-                                                [% IF ( biblioloo.none_avail ) %]
+                                                [% IF ( biblioloo.none_avail || biblioloo.noitems ) %]
                                                     <ul>
                                                 [% END %]
                                             [% END %]
@@ -316,14 +316,14 @@
                                                     <strong>already has a hold</strong> on this item
                                                 </li>
                                             [% END %]
-                                            [% IF ( biblioloo.none_avail ) %]
+                                            [% IF ( biblioloo.none_avail || biblioloo.noitems ) %]
                                                 <li> <strong>No items are available</strong> to be placed on hold</li>
                                             [% END %]
 
                                             [% IF ( biblioloo.alreadyres ) %]
                                                 </ul>
                                             [% ELSE %]
-                                                [% IF ( biblioloo.none_avail ) %]
+                                                [% IF ( biblioloo.none_avail || biblioloo.noitems ) %]
                                                     </ul>
                                                 [% END %]
                                             [% END %]
@@ -818,7 +818,7 @@
                                             [% IF ( biblioloo.alreadyres ) %]
                                                 <ul>
                                             [% ELSE %]
-                                                [% IF ( biblioloo.none_avail ) %]
+                                                [% IF ( biblioloo.none_avail || biblioloo.noitems ) %]
                                                     <ul>
                                                 [% END %]
                                             [% END %]
@@ -829,20 +829,20 @@
                                                     <strong>already has a hold</strong> on this item
                                                 </li>
                                             [% END %]
-                                            [% IF ( biblioloo.none_avail ) %]
+                                            [% IF ( biblioloo.none_avail || biblioloo.noitems ) %]
                                                 <li> <strong>No items are available</strong> to be placed on hold</li>
                                             [% END %]
 
                                             [% IF ( biblioloo.alreadyres ) %]
                                                 </ul>
                                             [% ELSE %]
-                                                [% IF ( biblioloo.none_avail ) %]
+                                                [% IF ( biblioloo.none_avail || biblioloo.noitems ) %]
                                                     </ul>
                                                 [% END %]
                                             [% END %]
                                         </td>
                                         <td>
-                                            [% UNLESS ( biblioloo.none_avail ) %]
+                                            [% UNLESS ( biblioloo.none_avail || biblioloo.noitems ) %]
                                                 <select name="pickup_[% biblioloo.biblionumber | html %]"
                                                         class="multi_pickup_select"
                                                         data-biblio-id="[% biblioloo.biblionumber | html %]"
-- 
2.39.5