From ffb5e5ec118ead43e563dc4748fd1cb267167176 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 25 Mar 2016 11:46:58 +0100 Subject: [PATCH] Bug 16004: [QA Follow-up] Tiny change for unit test and help file Unit test: Added a few lines to add the CPL branch the test depends on. Help file: Changed a few occurrences for new to new_status Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher --- .../help/tools/automatic_item_modification_by_age.tt | 8 ++++---- t/db_dependent/Items/AutomaticItemModificationByAge.t | 7 +++++++ 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/automatic_item_modification_by_age.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/automatic_item_modification_by_age.tt index ef4f6d7110..fc5ab9d594 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/automatic_item_modification_by_age.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/automatic_item_modification_by_age.tt @@ -3,11 +3,11 @@

This configuration page allows to configure the rules for the automatic item modifications by age cronjob script.

-

Libraries can manage the 'new' status for items. With this script, it will be possible to:

+

Libraries can manage the 'new_status' field for items. With this script, it will be possible to:

  • know easily what are the new items in the catalogue.
  • display an icon in the search results for new items.
  • -
  • configure circulation and fine rules depending the 'new' status.
  • +
  • configure circulation and fine rules depending the 'new_status' field.
  • get a RSS/Atom feeds on these new items.
@@ -23,11 +23,11 @@

At least one substitution must be defined, else there is no sense to launch the script.

If the value is an empty string, the field will be deleted.

Examples

-

You want to remove the items.new value for items created 10 days ago:

+

You want to remove the items.new_status value for items created 10 days ago:

  • Duration: 10 days
  • No condition
  • -
  • Substitution: items.new = '' (no value in the input)
  • +
  • Substitution: items.new_status = '' (no value in the input)

You want to change the items.ccode=1 to items.ccode=2 for items created 7 days ago. diff --git a/t/db_dependent/Items/AutomaticItemModificationByAge.t b/t/db_dependent/Items/AutomaticItemModificationByAge.t index 0bad51abf2..6d7abe2539 100644 --- a/t/db_dependent/Items/AutomaticItemModificationByAge.t +++ b/t/db_dependent/Items/AutomaticItemModificationByAge.t @@ -11,11 +11,18 @@ use C4::Biblio; use C4::Context; use C4::Items; use Koha::DateUtils; +use t::lib::TestBuilder; my $dbh = C4::Context->dbh; $dbh->{AutoCommit} = 0; $dbh->{RaiseError} = 1; +# this test assumes a CPL branch +my $builder = t::lib::TestBuilder->new; +if( !$builder->schema->resultset('Branch')->find('CPL') ) { + $builder->build( { source => 'Branch', value => { branchcode => 'CPL' }}); +} + $dbh->do(q| DELETE FROM marc_subfield_structure WHERE kohafield = 'items.new_status' OR kohafield = 'items.stocknumber' -- 2.39.5