]> git.koha-community.org Git - koha.git/commit
Bug 29771: Scalar context for split
authorTomas Cohen Arazi <tomascohen@theke.io>
Thu, 23 Dec 2021 19:58:57 +0000 (16:58 -0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Wed, 9 Mar 2022 09:03:34 +0000 (23:03 -1000)
commit9c7a7f7c86a5b401f035c2fd51ee745580ec34f4
treeddc3c3932f78ad1bb008a35ff0997985f505acdc
parent1570af154fe791d6dcac53f27ff8d7175b7a6095
Bug 29771: Scalar context for split

This patch tackles a very specific scenario. Calling split(...,
CGI::param) makes it be called in list context. The split docs say:

split /PATTERN/,EXPR,LIMIT

this means the first CGI param will be used as EXPR and the second one
as LIMIT, which is wrong anyway. So the fix is to just force scalar
context.

To test:
1. Not sure, just make sure nothing breaks when using the scripts in the
   browser.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
circ/article-request-slip.pl
circ/waitingreserves.pl
reserve/request.pl
tools/batch_delete_records.pl
tools/batch_record_modification.pl
tools/inventory.pl