]> git.koha-community.org Git - koha.git/commit
Bug 24313: Always display XSLT errors in logs
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 27 Dec 2019 13:55:36 +0000 (14:55 +0100)
committerHayley Mapley <hayleymapley@catalyst.net.nz>
Thu, 20 Feb 2020 03:11:13 +0000 (16:11 +1300)
commitb6a6bfb9fb346ffaf29f05b6283fa7173af3620f
tree755c20c7dd6147c8f13fd4eb03be3a6f311dd1e3
parent296524c9784145301eba713d4f5ffdc59d724577
Bug 24313: Always display XSLT errors in logs

From
  commit 295ae33800a322facfdf56795f4c02b2fd53432b
  Bug 20272: Replace error numbers by codes in XSLT_Handler

"""
    Make XSLT_Handler a little bit less noisy by defaulting print_warns to
    false unless $ENV{DEBUG} is set. (See also bug 19018).
"""

I think we should warn the errors in the logs. They are not debug messages here, we should not rely on DEBUG.
If too noisy we should fix the original issues, not hide all the errors (which make the XSLT debugging super hard)

Test plan:
Break a XSLT, reload the page and confirm that there are useful errors in the Koha log file

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
(cherry picked from commit ec79582374c829049ebac891644fb9f6e30a9614)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 8bcafbe3cfa15974b34c8bb8dc9d10f72205283e)

Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Koha/XSLT_Handler.pm