]> git.koha-community.org Git - koha.git/commit
Bug 18897: Use Module::Load::Conditional::can_load
authorMark Tompsett <mtompset@hotmail.com>
Fri, 1 Sep 2017 18:15:44 +0000 (14:15 -0400)
committerKatrin Fischer <katrin.fischer.83@web.de>
Fri, 6 Oct 2017 06:18:45 +0000 (08:18 +0200)
commitd708f5726658367212e96cd5de542d7658c7eae9
tree0bb2c167201670534a793194067a0dde8d3e7cc8
parent82db13b7116a202a3bc9baf81f198ef9a227b85e
Bug 18897: Use Module::Load::Conditional::can_load

Rather than rely on eval(), Jonathan Druart recommended in
comment #6 to use Use Module::Load::Conditional::can_load.
This addresses that concern.

TEST PLAN
---------
$ git fetch
$ git checkout -b bug_18897 origin/master
$ git bz apply 18897
$ sudo apt-get remove libcatmandu-store-elasticsearch-perl
...
$ prove t/db_dependent/Koha_Elasticsearch_Indexer.t
-- Note that the message says the correct library is missing.
$ sudo apt-get install libcatmandu-store-elasticsearch-perl
-- Note it runs as expected.
run the koha qa test tools

Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 088e332760b55c6f7a44097d8ab5d84003d8f0e0)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
t/db_dependent/Koha_Elasticsearch_Indexer.t