]> git.koha-community.org Git - koha.git/log
koha.git
13 years agobug 4826 change 'add basket' to 'new basket'
Nicole Engard [Wed, 15 Dec 2010 14:23:14 +0000 (09:23 -0500)]
bug 4826 change 'add basket' to 'new basket'

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for 5143, now with IE debug removed
Chris Cormack [Tue, 14 Dec 2010 19:20:42 +0000 (14:20 -0500)]
Fix for 5143, now with IE debug removed

Need to set up keyword to marc mappings for subtitle, parts, numbers for this to work

adds:
 - the subtitles into the title link (originally Chris Cormack)
 - barcodes for every listed hold
 - denoted which items were only item and which could be filled by any item on that bib.
 - added id's to every column for ease of jquery suppression of data (example: publication data or patron column could be suppressed)

[EDIT]: Added missing template variable
[EDIT]: Converted table cell IDs to classes. Having multiple identical IDs is invalid.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 3789 Set off shelving location in staff and OPAC title display
Jane Wagner [Tue, 14 Dec 2010 16:39:12 +0000 (11:39 -0500)]
Bug 3789 Set off shelving location in staff and OPAC title display

Koha puts the shelving location immediately after the library name in the
"Location" column of the title display.  If the library name and/or shelving
location is wordy, the two can run together and a user can overlook the
shelving location.  I've added a new span class to the staff and OPAC .css
files and applied it to shelving location in both templates.  This puts the
shelving location on a separate line and in italics, to make it stand out from
the library name.

[Edit] Re-implemented some changes which wouldn't merge after so long

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 4937: Fixes XHTML in the pagination links of a saved report.
Garry Collum [Tue, 14 Dec 2010 14:38:19 +0000 (09:38 -0500)]
Bug 4937: Fixes XHTML in the pagination links of a saved report.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 4977 add missing order links to 'no results found' page
Nicole Engard [Tue, 14 Dec 2010 13:57:46 +0000 (08:57 -0500)]
bug 4977 add missing order links to 'no results found' page

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoRevert "Ergonomy improvement in smart rule management"
Chris Cormack [Tue, 14 Dec 2010 20:03:11 +0000 (09:03 +1300)]
Revert "Ergonomy improvement in smart rule management"

This reverts commit fefd158f424939fc473f54a2ffe4ee0e39ffba08.

This was causing quite major errors, read the details at bug 5496

13 years agoAlternate fix for Bug 2981, removing onclick redirect
Owen Leonard [Mon, 13 Dec 2010 19:26:35 +0000 (14:26 -0500)]
Alternate fix for Bug 2981, removing onclick redirect

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'colin/QA/bug_4506' into new/enh/bug_4506
Chris Cormack [Tue, 14 Dec 2010 08:07:15 +0000 (21:07 +1300)]
Merge remote branch 'colin/QA/bug_4506' into new/enh/bug_4506

13 years agobug 5033: Add a reference to xml_sax to the Makefile.PL
Robin Sheat [Mon, 19 Jul 2010 02:06:32 +0000 (14:06 +1200)]
bug 5033: Add a reference to xml_sax to the Makefile.PL

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for intranet-tmpl had one /TMPL_IF to many
Chris Cormack [Tue, 14 Dec 2010 07:10:59 +0000 (20:10 +1300)]
Fix for intranet-tmpl had one /TMPL_IF to many

13 years agoFixes bug 5125: Default focus on circulation-home page
Ian Walls [Fri, 10 Sep 2010 16:43:18 +0000 (12:43 -0400)]
Fixes bug 5125: Default focus on circulation-home page

Fix created by Owen Leonard, related over IRC chat (rather than a patch file).

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoPossible fix for Bug 2307, Calendar widget cannot be translated
Owen Leonard [Tue, 14 Dec 2010 06:24:16 +0000 (07:24 +0100)]
Possible fix for Bug 2307, Calendar widget cannot be translated

This patch copies the calendar's language strings from a stand-
alone javascript file into calendar.inc where they can be
translated along with other strings.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/enh/bug_2965' into kcmaster
Chris Cormack [Tue, 14 Dec 2010 06:35:42 +0000 (19:35 +1300)]
Merge remote branch 'kc/new/enh/bug_2965' into kcmaster

13 years agoBug 2965: Allow due date in the past - small template fix
Katrin Fischer [Tue, 14 Dec 2010 05:33:27 +0000 (06:33 +0100)]
Bug 2965: Allow due date in the past - small template fix

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoAdd missing bracket to updatedatabase.pl
Katrin Fischer [Tue, 14 Dec 2010 06:26:09 +0000 (07:26 +0100)]
Add missing bracket to updatedatabase.pl

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5084 - hide funds that are part of an inactive budget
Robin Sheat [Wed, 4 Aug 2010 03:48:10 +0000 (15:48 +1200)]
Bug 5084 - hide funds that are part of an inactive budget

Prevents inactive funds from showing in the aquisitions module, they
still show in the administration.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 2965: Allow due date in the past
Srdjan Jankovic [Mon, 13 Dec 2010 21:34:07 +0000 (22:34 +0100)]
Bug 2965: Allow due date in the past

Raise warning rather than disallowing
Remove due date js validation when checking out

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixed small error in circulation.tmpl
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 5000, Uncertain prices misses option to choose display language
Owen Leonard [Mon, 13 Dec 2010 21:14:11 +0000 (22:14 +0100)]
Fix for Bug 5000, Uncertain prices misses option to choose display language

- Adding missing footer include for language chooser
- Correcting markup and structure errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoVariable redeclared in same scope
Colin Campbell [Mon, 13 Dec 2010 17:05:06 +0000 (17:05 +0000)]
Variable redeclared in same scope

lexical variable declared twice causing run time warnings

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 5255 change 'document type' to 'item type'
Nicole Engard [Mon, 13 Dec 2010 16:13:58 +0000 (11:13 -0500)]
bug 5255 change 'document type' to 'item type'

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 4252 add authorites permission to menus
Nicole Engard [Mon, 13 Dec 2010 15:27:47 +0000 (10:27 -0500)]
bug 4252 add authorites permission to menus

Added to more menu and to the main intranet page

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 2170 Supplementary Fix Wrap link in permissions check
Colin Campbell [Mon, 13 Dec 2010 15:31:47 +0000 (15:31 +0000)]
Bug 2170 Supplementary Fix Wrap link in permissions check

Found an edit item link not subject to edit_items permission check

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoUpdated fix for Bug 2170, Adding 'edititems' user-permission
Owen Leonard [Mon, 13 Dec 2010 15:30:07 +0000 (15:30 +0000)]
Updated fix for Bug 2170, Adding 'edititems' user-permission

This patch follows up on the addition of the 'edititems'
permission by adding a check of the new permission to places
in the interface which link to the edit item screen.

The catalogue toolbar had to be extensively re-worked in
order to ensure that the "New" and "Edit" menus would appear
(or not) whether or not edit_catalogue, edit_items, or
create_subscription permissions are on.

Revised for current HEAD

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5484 - Handling bad borrower categories in serial routing lists more gracefully
Chris Cormack [Mon, 13 Dec 2010 11:44:35 +0000 (11:44 +0000)]
Bug 5484 - Handling bad borrower categories in serial routing lists more gracefully

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'katrin/3381_intranetusercss' into new/enh/bug_3381
Chris Cormack [Mon, 13 Dec 2010 23:24:59 +0000 (12:24 +1300)]
Merge remote branch 'katrin/3381_intranetusercss' into new/enh/bug_3381

Conflicts:
installer/data/mysql/it-IT/necessari/sysprefs.sql
kohaversion.pl

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/biblibre_reports' into kcmaster
Chris Cormack [Mon, 13 Dec 2010 17:31:00 +0000 (06:31 +1300)]
Merge remote branch 'kc/new/biblibre_reports' into kcmaster

13 years agobug 5150 change issuing to circ & fine rules
Nicole Engard [Wed, 18 Aug 2010 01:22:56 +0000 (21:22 -0400)]
bug 5150 change issuing to circ & fine rules

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_4218' into kcmaster
Chris Cormack [Mon, 13 Dec 2010 09:55:23 +0000 (22:55 +1300)]
Merge remote branch 'kc/new/bug_4218' into kcmaster

13 years agoBug 4218: Fixes display problem introduced by last patch
Katrin Fischer [Tue, 7 Dec 2010 03:47:35 +0000 (04:47 +0100)]
Bug 4218: Fixes display problem introduced by last patch

Adds back missing <!-- /TMPL_IF -->.
Without navigation tabs and holdigns are not displayed in staff detail.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 5208, Language chooser missing on Batch item deletion/modification
Owen Leonard [Fri, 10 Sep 2010 12:37:55 +0000 (14:37 +0200)]
Fix for Bug 5208, Language chooser missing on Batch item deletion/modification

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5228 - make rebuild_zebra handle fixing the zebra dirs
Robin Sheat [Thu, 16 Sep 2010 07:08:57 +0000 (19:08 +1200)]
Bug 5228 - make rebuild_zebra handle fixing the zebra dirs

If the zebra server directories don't exist, zebra will spit the dummy.
This makes rebuild_zebra.pl smart enough to create them if they're not
there. If that fails, it'll scream loudly so you know zebra isn't
reindexing.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5313 - allow creation of libraries with hyphens
Robin Sheat [Wed, 20 Oct 2010 01:28:29 +0000 (14:28 +1300)]
Bug 5313 - allow creation of libraries with hyphens

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 5416, Template syntax error in moredetails.tmpl
Owen Leonard [Wed, 24 Nov 2010 14:48:24 +0000 (09:48 -0500)]
Fix for Bug 5416, Template syntax error in moredetails.tmpl

Credit for finding this bug and patching it goes to Fridolyn Somers,
but the patch in Bugzilla didn't apply for me so I duplicated the
changes and reformatted.
--
Owen

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5041 Allow to delete non-repeatable field
Frédéric Demians [Tue, 20 Jul 2010 12:03:35 +0000 (14:03 +0200)]
Bug 5041 Allow to delete non-repeatable field

Minus links wasn't displayed as it should in order to allow cataloger to
delete (empty all subfields) a non repeatable subfield.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/enh/bug_1997' into kcmaster
Chris Cormack [Mon, 13 Dec 2010 07:04:11 +0000 (20:04 +1300)]
Merge remote branch 'kc/new/enh/bug_1997' into kcmaster

13 years agoBug 1997: new OPACNoResultsFound pref
Katrin Fischer [Sat, 11 Dec 2010 20:13:06 +0000 (21:13 +0100)]
Bug 1997: new OPACNoResultsFound pref

This patch is a follow up - adding new system preference to all translated sql files.

13 years agoBug 3381 - Add an IntranetUserCSS system preference
Katrin Fischer [Sat, 11 Dec 2010 22:47:47 +0000 (23:47 +0100)]
Bug 3381 - Add an IntranetUserCSS system preference

Add an IntranetUserCSS sys pref that works like OPACUserCSS in OPAC only for intranet.

13 years ago(bug #3575) fix opac-detail.pl
Nahuel ANGELINETTI [Fri, 11 Sep 2009 14:34:00 +0000 (16:34 +0200)]
(bug #3575) fix opac-detail.pl

This delete an useless "use C4::Serials"(there are 2).

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years ago(bug #5154) fix most checkouts report
Nahuel ANGELINETTI [Thu, 19 Aug 2010 13:48:21 +0000 (15:48 +0200)]
(bug #5154) fix most checkouts report

Ignore null/deleted borrowers

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge branch 'new/bug_4218' into kcmaster
Chris Cormack [Mon, 13 Dec 2010 02:57:17 +0000 (15:57 +1300)]
Merge branch 'new/bug_4218' into kcmaster

13 years agoFix for Bug 4218 - Staff client detail page does not show item hold status
Owen Leonard [Tue, 21 Sep 2010 14:45:03 +0000 (10:45 -0400)]
Fix for Bug 4218 - Staff client detail page does not show item hold status

Showing "on hold" in the holdings list (as we used to do) is misleading
if it is a bibilo-level hold. However seeing that a title has holds
is important information for this view. This patch adds a line to the
biblio-level information display with a count of the title's outstanding
holds.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years ago(BUG #4806) circ/circulation.tmpl: Add "reservenumber" in the reserved table.
Alex Arnaud [Mon, 24 May 2010 09:56:48 +0000 (11:56 +0200)]
(BUG #4806) circ/circulation.tmpl: Add "reservenumber" in the reserved table.

Add "reservenumber" the "reserved" table which is used for delete or update reserved items.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoUpdate Debian changelog for 3.2.1 release
Robin Sheat [Sun, 12 Dec 2010 22:20:03 +0000 (11:20 +1300)]
Update Debian changelog for 3.2.1 release

This adds the required changelog changes to keep it current for the
3.2.1 release. It is intended to go straight into 3.2.x, and probably
should go into master also.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBumping db version
Chris Cormack [Sun, 12 Dec 2010 21:24:46 +0000 (10:24 +1300)]
Bumping db version

13 years agoBug 1997: new OPACNoResultsFound pref
Nicole Engard [Sat, 11 Dec 2010 20:17:55 +0000 (21:17 +0100)]
Bug 1997: new OPACNoResultsFound pref

This patch adds a new preference to allow librarians to
add content to the no results found page if they want.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Changed surrounding <p> in template to <div id="noresultsfound">
Will send follow up patch adding sys pref to translated sql files
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5483 New Icon Set
Nicole Engard [Sat, 11 Dec 2010 14:43:30 +0000 (09:43 -0500)]
Bug 5483 New Icon Set

Icon set sponsored by the Allen Ginsberg Library
at Naropa University sponsored this icon set
named Seshat, after the Egyptian goddess
of libraries, and designed by Jen Tobias.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 5443, Inaccurate highlighting of fields in patron update email
Owen Leonard [Fri, 10 Dec 2010 15:32:20 +0000 (15:32 +0000)]
Fix for Bug 5443, Inaccurate highlighting of fields in patron update email

- email was incorrectly named emailaddress
- string processing was being done to address and B_address
  which didn't seem to be serving a purpose

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 1883, authorised list of reasons why patron requesting book
Owen Leonard [Fri, 10 Dec 2010 15:03:33 +0000 (15:03 +0000)]
Fix for Bug 1883, authorised list of reasons why patron requesting book

- Adding form controls to opac submission form and staf client
  edit form.
- Adding display of patron reason for suggestion on opac list
- Adding function for pulling an authorized value description
  using the category and value

TODO: Add some default authorised values

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 4173 - Statuses not appearing in the OPAC
Owen Leonard [Fri, 10 Dec 2010 14:33:36 +0000 (14:33 +0000)]
Fix for Bug 4173 - Statuses not appearing in the OPAC

This adds display of "Use restrictions" authorized values
to the OPAC and the staff client for available and
not-for-loan items.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 5285, Show/hide columns in the output of items in batch operations
Owen Leonard [Thu, 9 Dec 2010 17:57:49 +0000 (17:57 +0000)]
Fix for Bug 5285, Show/hide columns in the output of items in batch operations

Also adds title/author information to output of batch deletions

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 4473 - Recent comments view for the OPAC
Owen Leonard [Thu, 9 Dec 2010 17:41:03 +0000 (17:41 +0000)]
Fix for Bug 4473 - Recent comments view for the OPAC

- modifies opac-showreviews.pl to display recent comments for all
  titles, sorted in descending order by date.
- includes RSS feed
- includes (thanks to Chris N.):

[Enhancement][3.4] Add RFC822 Format to C4::Dates

This patch adds RFC822 formatting to C4::Dates. It also updates Dates.t
appropriately. Consult the POD for this module for how to use
this format.

Please note that this module *does not* handle TZ conversion at this point.
This means that the TZ portion of a RFC822 time will be truncated and the converted
time will be in the same TZ as was passed in. When generating an RFC822 time,
the local TZ offset will be included since none of the other supported formats
provide a means for including their TZ. This is not a problem introduced by the
addition of RFC822 formatting. Rather it is due to this module not having TZ
support to begin with.

Also note that the dow, moy abbreviations are English as required by
RFC822 section 3.3 (thanks to self for pointing that out).

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5464 Suggestions - adding more acq fields to staff interface
Amit Gupta [Thu, 9 Dec 2010 14:15:22 +0000 (14:15 +0000)]
Bug 5464 Suggestions - adding more acq fields to staff interface

More acq fields in staff interface - price, quantity, currency and totals

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5391 - can't add multiples to batch
Chris Nighswonger [Fri, 12 Nov 2010 19:56:25 +0000 (14:56 -0500)]
Bug 5391 - can't add multiples to batch

This was due to the use of an OR which seems to have caused the
param method to be called in a scalar context thus returning only
the first of multiple repeated cgi params.

This patch retains the intent of the OR by replacing it with a
conditional.

Signed-off-by: Koustubha Kale <kmkale@anantcorp.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5423: Deleted Patrons are no longer saved in table deletedborrowers
Katrin Fischer [Mon, 6 Dec 2010 07:28:38 +0000 (08:28 +0100)]
Bug 5423: Deleted Patrons are no longer saved in table deletedborrowers

Tested with HEAD
> Should also apply to 3.2.x
( Not tested with 3.2.x)

Signed-off-by: Koustubha Kale <kmkale@anantcorp.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoAdding another developer to the Koha history, 120 now!
Chris Cormack [Sun, 12 Dec 2010 09:57:28 +0000 (22:57 +1300)]
Adding another developer to the Koha history, 120 now!

13 years agobug5455 (Fix uninitialized-warnings on authorities.pl)
Marcel de Rooy [Thu, 9 Dec 2010 12:36:07 +0000 (12:36 +0000)]
bug5455 (Fix uninitialized-warnings on authorities.pl)

Fix warnings for uninitialized authtypecode on lines 646, 653.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5479 - Update package building scripts
Robin Sheat [Thu, 9 Dec 2010 01:27:43 +0000 (14:27 +1300)]
Bug 5479 - Update package building scripts

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_4935' into kcmaster
Chris Cormack [Sun, 12 Dec 2010 08:08:19 +0000 (21:08 +1300)]
Merge remote branch 'kc/new/bug_4935' into kcmaster

13 years agoBug 4935: fix for allowing authorized values to be "unset"
Liz Rea [Wed, 8 Dec 2010 20:15:10 +0000 (15:15 -0500)]
Bug 4935: fix for allowing authorized values to be "unset"

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoUpdating test for systprefs to give more useful output
Chris Cormack [Sun, 12 Dec 2010 07:48:56 +0000 (20:48 +1300)]
Updating test for systprefs to give more useful output

13 years agoBumping version number
Chris Cormack [Sun, 12 Dec 2010 07:42:43 +0000 (20:42 +1300)]
Bumping version number

13 years agoBug 5418: Rev-5 patch new itemBarcodeInputFilter for libsuite8 style barcodes
Koustubha Kale [Tue, 7 Dec 2010 03:06:47 +0000 (04:06 +0100)]
Bug 5418: Rev-5 patch new itemBarcodeInputFilter for libsuite8 style barcodes

In India a ILS product called Libsuite8 prints barcodes like b0007432. The barcode is not stored anywhere in libsuite8's database. Neither is barcode available in any of the reports generated by the software.

The barcode 'b0007432' when scanned into the libsuite8 software is de-constructed like 'b' which is the itemtype i.e. Book in this instance, and '7432' which is the 'Accession Number'. The software then takes the logged in staff's branchcode and does a join on three tables 'Location', 'Media_Type', and 'Books' to retrieve the particular record from the database.

There is no possibility of recreating the barcodes for insertion in Koha while doing a retrospective conversion, because of arbitrary length of the barcode string AND arbitrary number of zeros in the numeric part of the printed barcode AND the fact that there are no reports available from the software which contain barcodes AND the fact that the barcode is not stored in the database.
But most importantly due to the simple fact that printed barcodes are duplicated among branches.

Therefore this patch emulates the functionality of Libsuite8 software of converting the scanned barcode into one stored in Koha using the itemBarcodeInputFilter system preference.

To use this new itemBarcodeInputFilter systempreference choice called 'libsuite8', the barcodes stored in Koha must match the pattern of <branchcode>-<itemtype_code>-<accession_number>. This is easy to achieve while doing retrospective conversion from Libsuite8 to Koha.

As expected the itemBarcodeInputFilter will return unmodified barcode if presented with a barcode of pattern <branchcode>-<itemtype_code>-<accession_number>

This revision corrects the way updatedatabase.pl is changed in order to correctly update version and insert the libsuite8 option in the database. Also kohaversion.pl is changed in the recommended format of 3.0X.0X.XXX to reflect database has changed.

This revision also changes the erronorous itemBarcodeInputFilter description in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref from 'scanned patron barcodes' to 'scanned item barcodes' there by eliminating need for a separate patch for bug 5417.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
1) applied patch to HEAD
2) set next database number in kohaversion.pl and updatedatabase.pl
3) webinstaller kicked in, update ok
4) typed the barcodes from test cases into check-in

Barcodes used my local branch code, everything seemed ok to me.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 2808, Hold queue not alphabetizing
Owen Leonard [Mon, 6 Dec 2010 21:07:02 +0000 (22:07 +0100)]
Fix for Bug 2808, Hold queue not alphabetizing

White space in the biblio-default-view include and in the page
template caused sorting on title or patron to be incorrect.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5475 Wrong messages date formating on Check Out page
Frédéric Demians [Mon, 6 Dec 2010 19:52:06 +0000 (14:52 -0500)]
Bug 5475 Wrong messages date formating on Check Out page

On the Check Out page, messages related to the borrower are displayed on the
right side. Message text is preceded by a date and library code. The date is
displayed in US format (mm/dd/YYY). Is should be displayed formated depending
on 'dateformat' syspref.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoErgonomy improvement in smart rule management
Jean-André Santoni [Mon, 6 Dec 2010 18:00:21 +0000 (18:00 +0000)]
Ergonomy improvement in smart rule management

Added a jQuery table filter, usefull when you have a lot of rows. This filter works on the entire row and allows you for exemple to type "Adul Perio 5".
Indentation cleaning.
Added tabs to filter colums on 4 axes: All, Issues, Fines and Reserves.
Moved the table filter to the right of the tabs.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 4500 - remove commas from price formatting
Robin Sheat [Mon, 6 Dec 2010 15:58:04 +0000 (16:58 +0100)]
Bug 4500 - remove commas from price formatting

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5022 Supplements were not saved correctly
Colin Campbell [Mon, 6 Dec 2010 15:48:47 +0000 (16:48 +0100)]
Bug 5022 Supplements were not saved correctly

No subscription id was set
Also entered a default arrived date on the supplement
And removed errors due to bad dates returned from GetSerials

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for 4832 - Re-editing a suggestion changes the item type
Owen Leonard [Mon, 6 Dec 2010 15:41:17 +0000 (16:41 +0100)]
Fix for 4832 - Re-editing a suggestion changes the item type

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5467: Kits shown wrong as visual material in XSLT displays
Katrin Fischer [Mon, 6 Dec 2010 14:55:03 +0000 (09:55 -0500)]
Bug 5467: Kits shown wrong as visual material in XSLT displays

- reused icon for mixed materials for kits
- fixed missing icon for mixed materials

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5446 Item creation in Acquisition module doesn't control mandatory field
f.demians at tamil.fr [Fri, 26 Nov 2010 07:22:45 +0000 (08:22 +0100)]
Bug 5446 Item creation in Acquisition module doesn't control mandatory field

Add some JS validing form, so saving an order is blocked if any item mandatory
field is empty.

Signed-off-by: Koustubha Kale <kmkale@anantcorp.com>
13 years agoAdd BSZ to Koha's About page
Katrin Fischer [Wed, 15 Sep 2010 12:47:55 +0000 (14:47 +0200)]
Add BSZ to Koha's About page

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoRemove some whitespace from earlier commit
Colin Campbell [Wed, 8 Dec 2010 12:54:58 +0000 (12:54 +0000)]
Remove some whitespace from earlier commit

13 years agoBug 4506: Correct wrong links in intranet
Katrin Fischer [Mon, 27 Sep 2010 04:56:04 +0000 (06:56 +0200)]
Bug 4506: Correct wrong links in intranet

Set links in intranet were opac links.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
13 years agoBug 4506: Add rcn links to host item entry = 773
Katrin Fischer [Mon, 27 Sep 2010 04:47:57 +0000 (06:47 +0200)]
Bug 4506: Add rcn links to host item entry = 773

Add links using control number in $w to host item entry.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
13 years agoBug 4506: Add rcn links to 780 and 785
Katrin Fischer [Mon, 27 Sep 2010 04:34:18 +0000 (06:34 +0200)]
Bug 4506: Add rcn links to 780 and 785

Add links using control number in $w to preceeding and succeeding entry.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
13 years agoBug 4506: Add link to volumes of traced series to series record
Katrin Fischer [Mon, 27 Sep 2010 04:17:16 +0000 (06:17 +0200)]
Bug 4506: Add link to volumes of traced series to series record

Changed link to volumes of sets to work for traced series too.
Now if the user finds a series or set record in the database,
there is always a link to search for the associated recos with items.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
13 years agoBug 4506: Traced series
Katrin Fischer [Mon, 27 Sep 2010 03:57:16 +0000 (05:57 +0200)]
Bug 4506: Traced series

Add separate display of traced series.
Use $w and index rcn for link if $w exists, else show text link.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
13 years agoBug 4506: Add links to other editions, some minor corrections
Katrin Fischer [Sun, 26 Sep 2010 23:55:45 +0000 (01:55 +0200)]
Bug 4506: Add links to other editions, some minor corrections

A new label 'Other editions:' is added with links to other editions.
The link starts a search for control number from 775$w in index control number.

A check for existence of $w/001 is added to always provide a fallback to a search for the link text.

Take care of repeated 773 fields.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
13 years agoBug 4506: Add volume > set link
Katrin Fischer [Sun, 26 Sep 2010 21:42:07 +0000 (23:42 +0200)]
Bug 4506: Add volume > set link

A new label 'Set:' is added with a link to the set.
The link starts a search for control number from 773$w in index control number.
A syspref UseControlNumber will be added later, to provide a fallback to a search by 245$a, which is also the title of the set.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
13 years agoBug 4506: Add set > volume link
Katrin Fischer [Sun, 26 Sep 2010 21:21:43 +0000 (23:21 +0200)]
Bug 4506: Add set > volume link

A new label 'Volumes:' is added with a link 'Show volumes'.
The link starts a search fcontrol number from 001 in index rcn = Record control number.
A syspref UseControlNumber will be added later, to provide a fallback to a search by title.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
13 years agoBug 4506: New icon for sets
Katrin Fischer [Sun, 26 Sep 2010 20:44:15 +0000 (22:44 +0200)]
Bug 4506: New icon for sets

Show an own icon for sets - LDR 19 = a

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
13 years agoBUG 4506: Add 8xx $w subfields to MARC-Frameworks de-DE
Katrin Fischer [Thu, 17 Jun 2010 15:28:07 +0000 (17:28 +0200)]
BUG 4506: Add 8xx $w subfields to MARC-Frameworks de-DE

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
13 years agoBug 4506: Some work on article to serial links
Katrin Fischer [Sun, 26 Sep 2010 19:35:34 +0000 (21:35 +0200)]
Bug 4506: Some work on article to serial links

- changes search links to use Title index
- show article icon in intranet like in opac

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
13 years agoBUG 4506: Add 8xx $w subfields to MARC-Frameworks pl-PL
Katrin Fischer [Sun, 23 May 2010 14:36:29 +0000 (16:36 +0200)]
BUG 4506: Add 8xx $w subfields to MARC-Frameworks pl-PL

ru-RU and uk-UA have no files for MARC21

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
13 years agoBUG 4506: Add 8xx $w subfields to MARC-Frameworks en, fr-FR
Katrin Fischer [Fri, 21 May 2010 16:00:05 +0000 (18:00 +0200)]
BUG 4506: Add 8xx $w subfields to MARC-Frameworks en, fr-FR

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
13 years agoBug 4506: Add index Record-control-number = rcn for indexing of $w subfields
Katrin Fischer [Fri, 14 May 2010 16:01:56 +0000 (18:01 +0200)]
Bug 4506: Add index Record-control-number = rcn for indexing of $w subfields

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
13 years agoIncremental fix for Bug 3285 - Location on Add Subscription should be pull down
Owen Leonard [Mon, 6 Dec 2010 11:56:12 +0000 (11:56 +0000)]
Incremental fix for Bug 3285 - Location on Add Subscription should be pull down

- Adds location dropdown to subscription edit form
- Pulls authorised value for display on subscription detail page
- Adds function for pulling authorised value description based
  on category and value

This patch does NOT implement automatic preselection of the shelving
location form field on the serial add item screen. This must be
worked out in order for the bug to be closed.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5460: AutoEmailPrimaryAddress set to invalid value in sysprefs.sql
Ian Walls [Thu, 2 Dec 2010 14:45:29 +0000 (09:45 -0500)]
Bug 5460: AutoEmailPrimaryAddress set to invalid value in sysprefs.sql

Fixes de-DE, en, fr-FR, pl-PL, ru-RU and uk-UA default install values for this system preference (changing from '0'
to 'OFF', the preferred value).

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5457: gather_print_notices.pl requires explicit stylesheet
Ian Walls [Thu, 2 Dec 2010 14:29:27 +0000 (09:29 -0500)]
Bug 5457: gather_print_notices.pl requires explicit stylesheet

Adds a conditional around the opening and closing of STYLESHEET, testing on whether the $stylesheet variable is set
or not.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 5397: display renew count consistently
Galen Charlton [Sat, 13 Nov 2010 03:00:27 +0000 (22:00 -0500)]
bug 5397: display renew count consistently

Display the renewal count for loans consistently; in particular,
for loans that have never been renewed, display 0.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/enh/bug_4983' into kcmaster
Chris Cormack [Thu, 2 Dec 2010 23:55:25 +0000 (12:55 +1300)]
Merge remote branch 'kc/new/enh/bug_4983' into kcmaster

13 years agoMerge remote branch 'kc/new/bug_4851' into kcmaster
Chris Cormack [Thu, 2 Dec 2010 23:55:20 +0000 (12:55 +1300)]
Merge remote branch 'kc/new/bug_4851' into kcmaster

13 years agoFix for Bug 4983 - Add edit record / edit item links to search results
Owen Leonard [Sat, 13 Nov 2010 18:06:50 +0000 (13:06 -0500)]
Fix for Bug 4983 - Add edit record / edit item links to search results

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 4851 - Batch delete shouldn't show delete button if no items were found
Owen Leonard [Sat, 13 Nov 2010 18:42:35 +0000 (13:42 -0500)]
Fix for Bug 4851 - Batch delete shouldn't show delete button if no items were found

- Adding template flag to indicate valid results (hidden or not)
 - Clarifying warning messages based on various outcomes

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 4908: rename temlate variable to branchname
Galen Charlton [Sat, 13 Nov 2010 19:08:59 +0000 (14:08 -0500)]
bug 4908: rename temlate variable to branchname

Using branchname is more accurate and could avoid
a bug if/when the patron update function is made more
sophisticated.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 4908 - OPAC patron details page doesn't show patron's home library
Owen Leonard [Sat, 13 Nov 2010 19:08:58 +0000 (14:08 -0500)]
Fix for Bug 4908 - OPAC patron details page doesn't show patron's home library

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5104: Add control number as search option to acq z39.50 search
Katrin Fischer [Thu, 2 Dec 2010 12:45:13 +0000 (12:45 +0000)]
Bug 5104: Add control number as search option to acq z39.50 search

Adds control number as search option to z39.50 search in acquisitions.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 5048, Error in menu/submenu for select language in intranet
Owen Leonard [Sat, 13 Nov 2010 19:14:39 +0000 (14:14 -0500)]
Fix for Bug 5048, Error in menu/submenu for select language in intranet

Patch for HEAD. This issue was apparently solved quite a while
ago in the OPAC. This patch copies that solution over to the staff client.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_5030' into kcmaster
Chris Cormack [Wed, 1 Dec 2010 20:20:14 +0000 (09:20 +1300)]
Merge remote branch 'kc/new/bug_5030' into kcmaster

13 years agoFix for Bug 5030 - Improve handling of duplicate patrons
Owen Leonard [Sat, 13 Nov 2010 19:34:42 +0000 (14:34 -0500)]
Fix for Bug 5030 - Improve handling of duplicate patrons

- Making duplicate patron warning dialog simpler but more explicit
- Pointing duplicate patron preview window to new brief version
  of moremember.pl to display more patron details than the previous
  version.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>