From 4eda276c1868fd0636dff0a19cdd30832f1ea3a3 Mon Sep 17 00:00:00 2001
From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Date: Mon, 27 Jun 2022 16:36:09 +0100
Subject: [PATCH] Bug 28854: (follow-up) Add handling for part_numbers/names

This patch adds part number/name handling to the new biblio-format js
include. This will add such details to bundle management tables.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 .../prog/en/includes/js-biblio-format.inc     | 62 ++++++++++++-------
 1 file changed, 38 insertions(+), 24 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/js-biblio-format.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/js-biblio-format.inc
index 32d5b1898e..fe43954c22 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/js-biblio-format.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/js-biblio-format.inc
@@ -1,47 +1,61 @@
 <script>
     (function() {
         /**
-        * Format the biblio response from a Koha RESTful API request.
-        * @param  {Object}  biblio  The biblio json object as returned from the Koha RESTful API
-        * @param  {Object}  config  A configuration object
-        *                           Valid keys are: `link`
-        * @return {string}          The formatted HTML string
-        */
-        window.$biblio_to_html = function( biblio, config ) {
+         * Format the biblio response from a Koha RESTful API request.
+         * @param  {Object}  biblio  The biblio json object as returned from the Koha RESTful API
+         * @param  {Object}  config  A configuration object
+         *                           Valid keys are: `link`
+         * @return {string}          The formatted HTML string
+         */
+        window.$biblio_to_html = function(biblio, config) {
 
-            if ( biblio === undefined ) {
+            if (biblio === undefined) {
                 return ''; // empty string for no biblio
             }
 
             var title = '<span class="biblio-title">';
-            if ( biblio.title != null && biblio.title != '' ) {
+            if (biblio.title != null && biblio.title != '') {
                 title += escape_str(biblio.title);
             } else {
                 title += __("No title");
             }
             title += '</span>';
 
-            if ( biblio.subtitle != null && biblio.subtitle != '' ) {
-                title += '<span clas="biblio-subtitle">' + escape_str(biblio.subtitle) + '</span>';
+            // add subtitle
+            if (biblio.subtitle != null && biblio.subtitle != '') {
+                title += '<span class="biblio-subtitle">' + escape_str(biblio.subtitle) + '</span>';
             }
 
+            // set title as link
             if (config && config.link) {
-                if ( config.link === 'marcdetail' ) {
-                    title = '<a href="/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber='+ encodeURIComponent(biblio.biblio_id) +'">' + title + '</a>';
-                }
-                else if ( config.link === 'labeled_marc') {
-                    title = '<a href="/cgi-bin/koha/catalogue/labeledMARCdetail.pl?biblionumber='+ encodeURIComponent(biblio.biblio_id) +'">' + title + '</a>';
-                }
-                else if ( config.link === 'isbd' ) {
-                    title = '<a href="/cgi-bin/koha/catalogue/ISBDdetail.pl?biblionumber='+ encodeURIComponent(biblio.biblio_id) +'">' + title + '</a>';
-                }
-                else {
-                    title = '<a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber='+ encodeURIComponent(biblio.biblio_id) +'">' + title + '</a>';
+                if (config.link === 'marcdetail') {
+                    title = '<a href="/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=' + encodeURIComponent(biblio.biblio_id) + '" class="title">' + title + '</a>';
+                } else if (config.link === 'labeled_marc') {
+                    title = '<a href="/cgi-bin/koha/catalogue/labeledMARCdetail.pl?biblionumber=' + encodeURIComponent(biblio.biblio_id) + '" class="title">' + title + '</a>';
+                } else if (config.link === 'isbd') {
+                    title = '<a href="/cgi-bin/koha/catalogue/ISBDdetail.pl?biblionumber=' + encodeURIComponent(biblio.biblio_id) + '" class="title">' + title + '</a>';
+                } else {
+                    title = '<a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=' + encodeURIComponent(biblio.biblio_id) + '" class="title">' + title + '</a>';
                 }
             }
 
-            if ( biblio.medium != null && biblio.medium != '' ) {
-                title +=  '<span class="biblio-medium">'+escape_str(biblio.medium)+'</span>';
+            // add medium
+            if (biblio.medium != null && biblio.medium != '') {
+                title += '<span class="biblio-medium">' + escape_str(biblio.medium) + '</span>';
+            }
+
+            // add part numbers/names
+            let part_numbers = (typeof biblio.part_number === 'string') ? biblio.part_number.split("|") : [];
+            let part_names = (typeof biblio.part_name === 'string') ? biblio.part_name.split("|") : [];
+            let i = 0;
+            while (part_numbers[i] || part_names[i]) {
+                if (part_numbers[i]) {
+                    title += '<span class="part-number">' + escape_str(part_numbers[i]) + '</span>';
+                }
+                if (part_names[i]) {
+                    title += '<span class="part-name">' + escape_str(part_name[i]) + '</span>';
+                }
+                i++;
             }
 
             return title;
-- 
2.39.5