From 7829496f1180a8b47a866fff1a2e061bbdcac2df Mon Sep 17 00:00:00 2001
From: Galen Charlton <gmc@esilibrary.com>
Date: Tue, 10 Dec 2013 20:20:37 +0000
Subject: [PATCH] Bug 11009: (follow-up) tweak wording and remove potential log
 noise

This patch makes the message that is displayed when attempting to
view circ history for the anonymous patron more informative.  It
also removes a potential source of log noise if the AnonymousPatron
system preference happens to be set to a blank value.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit d92dbae6814fd2dfc36f7f46194f02a9c27994fa)
Signed-off-by: Fridolin SOMERS <fridolin.somers@biblibre.com>
---
 koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt | 2 +-
 members/readingrec.pl                                         | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt
index 47ed060685..740fd3fd1d 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt
@@ -48,7 +48,7 @@
 <h1>Circulation history</h1>
 
 [% IF is_anonymous %]
-    <div class="dialog alert">This is the anonymous patron.</div>
+    <div class="dialog alert">This is the anonymous patron, so no circulation history is displayed. To get a list of anonymized loans, please run a report.</div>
 [% ELSIF ( !loop_reading ) %]
     <div class="dialog message">This patron has no circulation history.</div>
 [% ELSE %]
diff --git a/members/readingrec.pl b/members/readingrec.pl
index 2a57c42992..2cb9437591 100755
--- a/members/readingrec.pl
+++ b/members/readingrec.pl
@@ -65,7 +65,9 @@ my $order = 'date_due desc';
 my $limit = 0;
 my $issues = ();
 # Do not request the old issues of anonymous patron
-if ( $borrowernumber == C4::Context->preference('AnonymousPatron') ){
+if ( $borrowernumber eq C4::Context->preference('AnonymousPatron') ){
+    # use of 'eq' in the above comparison is intentional -- the
+    # system preference value could be blank
     $template->param( is_anonymous => 1 );
 } else {
     $issues = GetAllIssues($borrowernumber,$order,$limit);
-- 
2.39.5