From 25a2a7096327d4338b75c2c3cce6beee0b1f7a1a Mon Sep 17 00:00:00 2001 From: Andrew Fuerste-Henry Date: Thu, 27 Feb 2020 14:09:02 -0600 Subject: [PATCH] Bug 24747: Corrects on-screen instructions in branch transfer limits To test: 1- go to cgi-bin/koha/admin/branch_transfer_limits.pl 2- see wording "Check the boxes for the libraries you accept to checkin items from" 3- apply patch 4- see wording "Check the boxes for the libraries you allow your items to be transferred to" To verify new wording accuractely describes behavior: 1- Set UseBranchTransferLimits set to Enforce using itemtype 2- Confirm circ rules allow holds 3- Confirm hold policy by item type allows holds 4- Confirm all branches are valid pickup locations in branch setup 5- In Branch Transfer Limits, set dropdown to Branch A, select itemtype Book, disable all transfers so Branch A does not accept books from any other branch 6- Find a patron from Branch A 7- Find a book from Branch B 8- On the intranet, successfully place hold on item for patron for pickup at branch A 9- Cancel hold 10- Log into opac as patron 11- Successfully place hold on item for pickup at Branch A 12- Cancel hold 13- In Branch Transfer Limits, set dropdown to Branch A, select itemtype Book, ENABLE all transfers so Branch A DOES accept books from any other branch 14- In Branch Transfer Limits, set dropdown to Branch B, select itemtype Book, disable all transfers so Branch B does not accept books from any other branch 15- On the intranet, try to place a hold on item for patron, confirm Branch B is your only pickup option 16- On the OPAC, log in as patron, try to place a hold on item, confirm Branch B is your only pickup option Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 84026f258909e1203f34793a1089388cd933d1c9) Signed-off-by: Lucas Gass (cherry picked from commit 67a4e40f5cd1866d5ed27f211800731bd4c14764) --- .../prog/en/modules/admin/branch_transfer_limits.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt index 040772d0a5..f898f6d2ae 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt @@ -28,7 +28,7 @@ -

Check the boxes for the libraries you accept to checkin items from.

+

Check the boxes for the libraries you allow your items to be transferred to.

[% IF ( limitType == 'ccode' ) %]For all collection codes: [% ELSE %]For all item types: [% END %] Select all | Clear all
-- 2.39.5