From 6f9c968cccd46fc2bb5e82fd3bb17f966d180420 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 4 Jan 2022 15:40:19 +0100
Subject: [PATCH] Bug 29789: Remove unused $error from cataloguing/additem.pl

my $error        = $input->param('error');

It should be removed as $error is used later but not related to this variable.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit b85e3cb81181529698e39219fe5ccc9b62c7e243)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
---
 cataloguing/additem.pl | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl
index 0f3363e8ff..3bd999e9f4 100755
--- a/cataloguing/additem.pl
+++ b/cataloguing/additem.pl
@@ -390,7 +390,6 @@ sub removeFieldsForPrefill {
 }
 
 my $input        = CGI->new;
-my $error        = $input->param('error');
 
 my $biblionumber;
 my $itemnumber;
@@ -695,7 +694,7 @@ if ($op eq "additem") {
 #-------------------------------------------------------------------------------
     # check that there is no issue on this item before deletion.
     my $item = Koha::Items->find($itemnumber);
-    $error = $item->safe_delete;
+    my $error = $item->safe_delete;
     if(ref($error) eq 'Koha::Item'){
         print $input->redirect("additem.pl?biblionumber=$biblionumber&frameworkcode=$frameworkcode&searchid=$searchid");
     }else{
@@ -707,7 +706,7 @@ if ($op eq "additem") {
 #-------------------------------------------------------------------------------
     my $items = Koha::Items->search({ biblionumber => $biblionumber });
     while ( my $item = $items->next ) {
-        $error = $item->safe_delete({ skip_record_index => 1 });
+        my $error = $item->safe_delete({ skip_record_index => 1 });
         next if ref $error eq 'Koha::Item'; # Deleted item is returned if deletion successful
         push @errors,$error;
     }
-- 
2.39.5