From bc77ca128a630487c807cded01c9bfdfdf28b90e Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Mon, 6 May 2024 12:18:55 +0200
Subject: [PATCH] Bug 29948: Hide entry if empty

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 .../en/includes/authority-information.inc     | 140 ++++++++++--------
 1 file changed, 78 insertions(+), 62 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/authority-information.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/authority-information.inc
index 53e391da2b..9bd43f41ee 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/authority-information.inc
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/authority-information.inc
@@ -21,74 +21,90 @@
             [% END %]
         </li>
     [% CASE 'activity' %]
-        <li>
-            <span>
-                Field of activity: [% info.field_of_activity | html %]
-                [% IF info.start_period || info.end_period %]
-                    (
-                    [%~ IF info.start_period %]from: [% info.start_period | html %][% END %]
-                    [% IF info.end_period %]until: [% info.end_period | html %][% END ~%]
-                    )
-                [% END %]
-            </span>
-        </li>
+        [% IF info.field_of_activity %]
+            <li>
+                <span>
+                    Field of activity: [% info.field_of_activity | html %]
+                    [% IF info.start_period || info.end_period %]
+                        (
+                        [%~ IF info.start_period %]from: [% info.start_period | html %][% END %]
+                        [% IF info.end_period %]until: [% info.end_period | html %][% END ~%]
+                        )
+                    [% END %]
+                </span>
+            </li>
+        [% END %]
     [% CASE 'address' %]
-        <li>
-            <span>Address: [% info.address | html %] [% info.postal_code | html %] [% info.city | html %] [% info.country | html %]</span>
-        </li>
+        [% IF info.address %]
+            <li>
+                <span>Address: [% info.address | html %] [% info.postal_code | html %] [% info.city | html %] [% info.country | html %]</span>
+            </li>
+        [% END %]
     [% CASE 'associated_group' %]
-        <li>
-            <span>
-                Associated group: [% info.associated_group | html %]
-                [% IF info.start_period || info.end_period %]
-                    (
-                    [%~ IF info.start_period %]from: [% info.start_period | html %][% END %]
-                    [% IF info.end_period %]until: [% info.end_period | html %][% END ~%]
-                    )
-                [% END %]
-                [% IF info.uri %]<p>URI: [% info.uri | html %]</p>[% END %]
-                [% IF info.source_of_information %]<p>Source of information: [% info.source_of_information | html %]</p> [% END %]
-                [% IF info.authority_record_number %]<p>Authority record control number or standard number: [% info.authority_record_number | html %]</p>[% END %]
-            </span>
-        </li>
+        [% IF info.associated_group %]
+            <li>
+                <span>
+                    Associated group: [% info.associated_group | html %]
+                    [% IF info.start_period || info.end_period %]
+                        (
+                        [%~ IF info.start_period %]from: [% info.start_period | html %][% END %]
+                        [% IF info.end_period %]until: [% info.end_period | html %][% END ~%]
+                        )
+                    [% END %]
+                    [% IF info.uri %]<p>URI: [% info.uri | html %]</p>[% END %]
+                    [% IF info.source_of_information %]<p>Source of information: [% info.source_of_information | html %]</p> [% END %]
+                    [% IF info.authority_record_number %]<p>Authority record control number or standard number: [% info.authority_record_number | html %]</p>[% END %]
+                </span>
+            </li>
+        [% END %]
     [% CASE 'email_address' %]
-        <li>
-            <span>
-                Email address: [% info.email_address | html %]
-            </span>
-        </li>
+        [% IF info.email_address %]
+            <li>
+                <span>
+                    Email address: [% info.email_address | html %]
+                </span>
+            </li>
+        [% END %]
     [% CASE 'occupation' %]
-        <li>
-            <span>
-                Occupation: [% info.occupation | html %]
-                [% IF info.start_period || info.end_period %]
-                    (
-                    [%~ IF info.start_period %]from: [% info.start_period | html %][% END %]
-                    [% IF info.end_period %]until: [% info.end_period | html %][% END ~%]
-                    )
-                [% END %]
-                [% IF info.uri %]<p>URI: [% info.uri | html %]</p>[% END %]
-                [% IF info.source_of_information %]<p>Source of information: [% info.source_of_information | html %]</p> [% END %]
-                [% IF info.authority_record_number %]<p>Authority record control number or standard number: [% info.authority_record_number | html %]</p>[% END %]
-            </span>
-        </li>
+        [% IF info.occupation %]
+            <li>
+                <span>
+                    Occupation: [% info.occupation | html %]
+                    [% IF info.start_period || info.end_period %]
+                        (
+                        [%~ IF info.start_period %]from: [% info.start_period | html %][% END %]
+                        [% IF info.end_period %]until: [% info.end_period | html %][% END ~%]
+                        )
+                    [% END %]
+                    [% IF info.uri %]<p>URI: [% info.uri | html %]</p>[% END %]
+                    [% IF info.source_of_information %]<p>Source of information: [% info.source_of_information | html %]</p> [% END %]
+                    [% IF info.authority_record_number %]<p>Authority record control number or standard number: [% info.authority_record_number | html %]</p>[% END %]
+                </span>
+            </li>
+        [% END %]
     [% CASE 'place_of_birth' %]
-        <li>
-            <span>
-                Place of birth: [% info.place_of_birth | html %]
-            </span>
-        </li>
+        [% IF info.place_of_birth %]
+            <li>
+                <span>
+                    Place of birth: [% info.place_of_birth | html %]
+                </span>
+            </li>
+        [% END %]
     [% CASE 'place_of_death' %]
-        <li>
-            <span>
-                Place of death: [% info.place_of_death | html %]
-            </span>
-        </li>
+        [% IF info.place_of_death %]
+            <li>
+                <span>
+                    Place of death: [% info.place_of_death | html %]
+                </span>
+            </li>
+        [% END %]
     [% CASE 'uri' %]
-        <li>
-            <span>
-                URI: [% info.uri | $raw | html %]
-            </span>
-        </li>
+        [% IF info.uri %]
+            <li>
+                <span>
+                    URI: [% info.uri | $raw | html %]
+                </span>
+            </li>
+        [% END %]
     [% END %]
 [% END %]
-- 
2.39.5