]> git.koha-community.org Git - koha.git/commit
Bug 24254: Add Koha::Items->filter_by_visible_in_opac
authorTomas Cohen Arazi <tomascohen@theke.io>
Thu, 3 Dec 2020 18:11:14 +0000 (15:11 -0300)
committerVictor Grousset/tuxayo <victor@tuxayo.net>
Mon, 1 Feb 2021 20:15:36 +0000 (21:15 +0100)
commit66da038348e9c474fd04adcd6a34da884832ce5f
treeaf4acfa5a5ed66f9063346d3d18ab554939a20f9
parent6a48e25b01f30018981f7af3059ac32dea125359
Bug 24254: Add Koha::Items->filter_by_visible_in_opac

This patch adds a method based on the original idea from Nick, but on
Koha::Items.

The idea is to build a proper filter, based on the current rules for
hiding things, directly on the DBIC query. The caller takes care of
knowing if the filtering should apply (i.e. checking the patron category
exceptions) and then it would do something like:

    my @items;
    if ( <patron_category_does_not_have_exception> ) {
        @items = $biblio->items->filter_by_visible_in_opac(
            {
                rules => $rules
            }
        );
    }
    else {
        # still want to enforce 'hidelostitems'
        @items = $biblio->items->filter_by_visible_in_opac;
    }

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Items.t
=> SUCCESS: Tests pass!
3. Look at the use cases on the tests, read the code
=> SUCCESS: It all makes sense
4. Compare with Koha::Item->hidden_in_opac
=> SUCCESS: It all makes sense
5. Sign off :-D

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
(cherry picked from commit 11bdc847a38fa3631e39fbc19c05ea7e5e64afd3)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Koha/Items.pm