From b0d427115cfa18064cfc0405741aaf0f6a4e2a9a Mon Sep 17 00:00:00 2001
From: Nick Clemens <nick@bywatersolutions.com>
Date: Thu, 27 Apr 2023 11:23:03 +0000
Subject: [PATCH] Bug 33626: Remove invalid params

This patch reformats the params passed to scroll_helper as defined here:
https://metacpan.org/pod/Search::Elasticsearch::Client::7_0::Scroll

To test:
1 - perl misc/maintenance/compare_es_to_db.pl
2 - It dies:
[Param] ** Unknown param (scroll_in_qs) in (search) request. , called from sub Search::Elasticsearch::Client::7_0::Direct::scroll_helper at misc/maintenance/compare_es_to_db.pl line 55.
3 - Apply patch
4 - Repeat
5 - It succeeds!

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit daa92a937193321c49c97cca5bad8809d7889d21)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 38666a8bd784dafe2934bdbd6fb3f1693f9ae442)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 misc/maintenance/compare_es_to_db.pl | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/misc/maintenance/compare_es_to_db.pl b/misc/maintenance/compare_es_to_db.pl
index 6eaea29799..196ed2ea66 100755
--- a/misc/maintenance/compare_es_to_db.pl
+++ b/misc/maintenance/compare_es_to_db.pl
@@ -54,14 +54,12 @@ foreach my $index ( ('biblios','authorities') ){
     # The scroll lets us iterate through, it fetches chunks of 'size' as we move through
     my $scroll = $es->scroll_helper(
         index => $searcher->index_name,
-        size => 5000,
         body => {
+            size => 5000,
             query => {
                 match_all => {}
             },
-            stored_fields => []
         },
-        scroll_in_qs => 1,
     );
 
     my @es_ids;
-- 
2.39.5