]> git.koha-community.org Git - koha.git/commit
Bug 31086: Prevent placing hold with no pickup location
authorNick Clemens <nick@bywatersolutions.com>
Fri, 1 Jul 2022 14:46:26 +0000 (14:46 +0000)
committerArthur Suzuki <arthur.suzuki@biblibre.com>
Mon, 12 Sep 2022 11:52:25 +0000 (13:52 +0200)
commit3141773457057ec05e6cacdf9691a2b77738f4fd
tree6aa5cceb074152f66c3f0cf52511dfb3de066890
parent67513c6562b476b6ab0e218752c8bf4c145bb01f
Bug 31086: Prevent placing hold with no pickup location

To test:
1 - Apply patch
2 - Repeat test on previous patch
3 - You should get a warning popup when attempting to save hold
4 - Reload page
5 - Inspect the HTML and manualy set #pickup value of selected option to ""
6 - Attempt to save hold
7 - You get the popup
8 - Place a hold normally (with location) and verify it works

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit e609e20c041084a5b763f0b8fe8cd304e5ca8159)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 56f452c173156f3a83b7435c2ff95ed6dbe1d7f9)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt