From 392a7e1a1ffb327986a5c0cb6863bbb87e43deaf Mon Sep 17 00:00:00 2001 From: Didier Gautheron Date: Tue, 26 May 2020 13:31:31 +0200 Subject: [PATCH] Bug 25605: Replace NULL values with '' when downloading a report as a tab separated text Test plan : 1- Create a new report : select * from items; 2- Run it 3- Download the report as a tab separated text 4- There's a lot of 'use of uninitialized value in join or string at ...koha/reports/guided_reports.pl line xxx.' in plack-error.log 5- Apply patch 6- Restart all 7- Redo 2 and 3 8- No more warning. 9- diff both downloaded files, they must be the same. Signed-off-by: Marco Abi-Ramia Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart --- reports/guided_reports.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl index f52a6df432..4512ef574d 100755 --- a/reports/guided_reports.pl +++ b/reports/guided_reports.pl @@ -902,7 +902,7 @@ elsif ($phase eq 'Export'){ $content .= join("\t", header_cell_values($sth)) . "\n"; $content = Encode::decode('UTF-8', $content); while (my $row = $sth->fetchrow_arrayref()) { - $content .= join("\t", @$row) . "\n"; + $content .= join("\t", map { $_ // '' } @$row) . "\n"; } } else { my $delimiter = C4::Context->preference('delimiter') || ','; -- 2.39.5