From 3141773457057ec05e6cacdf9691a2b77738f4fd Mon Sep 17 00:00:00 2001
From: Nick Clemens <nick@bywatersolutions.com>
Date: Fri, 1 Jul 2022 14:46:26 +0000
Subject: [PATCH] Bug 31086: Prevent placing hold with no pickup location

To test:
1 - Apply patch
2 - Repeat test on previous patch
3 - You should get a warning popup when attempting to save hold
4 - Reload page
5 - Inspect the HTML and manualy set #pickup value of selected option to ""
6 - Attempt to save hold
7 - You get the popup
8 - Place a hold normally (with location) and verify it works

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit e609e20c041084a5b763f0b8fe8cd304e5ca8159)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 56f452c173156f3a83b7435c2ff95ed6dbe1d7f9)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
---
 koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
index 4ac89633ab..5a4d823566 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
@@ -1362,8 +1362,13 @@
                 else {
                     msg = (_("- Please select an item to place a hold") + "\n");
                 }
+            } else {
+                if( $("#pickup").length < 1 || $("#pickup").val() == "" ){
+                    msg = _("- Please select a pickup location for this hold" + "\n");
+                }
             }
 
+
             if (msg == "") {
                 $('#hold-request-form').preventDoubleFormSubmit();
                 return(true);
-- 
2.39.5