]> git.koha-community.org Git - koha.git/commit
Bug 14680: Always subtract discount from price to calculate estimated cost
authorNick Clemens <nick@bywatersolutions.com>
Tue, 12 Jul 2022 18:10:54 +0000 (18:10 +0000)
committerVictor Grousset/tuxayo <victor@tuxayo.net>
Sat, 10 Sep 2022 00:01:15 +0000 (02:01 +0200)
commitb494df730fd9891304dccf3eb2dc0831d12cd160
tree2f294f23cfe8584ce50f9177c79fb6a894221136
parent76095f9dc96fb7f8a136ff2ba81f01dd325a593b
Bug 14680: Always subtract discount from price to calculate estimated cost

This patch simply removes a discrepancty where when a discount is provided on the order form
we add the discount to the price, and when it comes form the vendor we subtract the discount.

Discounts should always descrease the estimated cost

To test:
 0 - Have a vendor with a discount of 10% specified
 1 - Export a record from your Koha
 2 - Stage the record for import and match on biblionumber
 3 - Add to a basket in acq from the staged file
 4 - Select the title, and set order price to $10 and do not fill the discount field
 5 - Add the order - note $10 RRP and $9 actual/budgeted cost
 6 - Repeat 2&3
 7 - Select the tile, set price $10 and discount 50%
 8 - Add the order - note $20 RRP and $10 actual/budgeted cost! FAIL
 9 - Apply patch, restart all
10 - Repeat 2-7
11 - Add the order, note $10 RRP and $5 actual.budgeted cost

Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 7c734c6903a823eeb58be9ab1c4af251def776b7)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 96eed0f5e00657808e506ba6d5e0a98a3529bf95)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
(cherry picked from commit da1633125fef9995bc9917693807ffb07054be15)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
acqui/addorderiso2709.pl