From 6cccf8f210b3fdf195d78185ea82b3504443880a Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Fri, 15 Mar 2024 09:05:55 -0300 Subject: [PATCH] Bug 36277: Avoid useless warnings As mentioned on bug 36329, this endpoint is only used with one of this parameters: * item_type * collection_code The other will be NULL both on the DB and the (deserialized) request body. For the data from the DB, the author added `|| q{}` but missed to do so on the incoming parameters when generates the hash key. This generates the following warnings when using from the UI: [2024/03/15 11:42:51] [WARN] Use of uninitialized value in sprintf at /kohadevbox/koha/Koha/REST/V1/TransferLimits.pm line 146. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer (cherry picked from commit 03b0f31b9e63ce314c333ac6ffd68587a609e587) Signed-off-by: Fridolin Somers (cherry picked from commit fa2e164f240a9e040c0e044c39dac6c613cb7b27) Signed-off-by: Lucas Gass --- Koha/REST/V1/TransferLimits.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Koha/REST/V1/TransferLimits.pm b/Koha/REST/V1/TransferLimits.pm index cba63776c1..b38c3e87eb 100644 --- a/Koha/REST/V1/TransferLimits.pm +++ b/Koha/REST/V1/TransferLimits.pm @@ -143,7 +143,7 @@ sub batch_add { my $dbic_params = Koha::Item::Transfer::Limits->new->attributes_from_api($params); my %existing_limits = - map { sprintf( "%s:%s:%s:%s", $_->fromBranch, $_->toBranch, $_->itemtype, $_->ccode ) => 1 } + map { sprintf( "%s:%s:%s:%s", $_->fromBranch, $_->toBranch, $_->itemtype // q{}, $_->ccode // q{} ) => 1 } Koha::Item::Transfer::Limits->search($dbic_params)->as_list; my @results; -- 2.39.5