From b9c1af5ef1ae233ec6e848d8700b53551d19bec4 Mon Sep 17 00:00:00 2001
From: Katrin Fischer <katrin.fischer.83@web.de>
Date: Thu, 17 Nov 2022 21:51:59 +0000
Subject: [PATCH] Bug 32200: Add page-section to checkout notes page

To test:
* Turn on AllowCheckoutNotes system preference
* Check out an item
* Go to the OPAC and add a checkout note to your checkout
* In the staff interface, look at: Circulation > Checkout notes
* Verify the page section is missing from the notes table
* Apply patch
* Verify the table now looks better!

Signed-off-by: David <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 .../prog/en/modules/circ/checkout-notes.tt    | 75 ++++++++++---------
 1 file changed, 38 insertions(+), 37 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt
index 91bd8e61a0..1e4eb701f0 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt
@@ -76,45 +76,46 @@
                         | <a class="ShowAll"><i class="fa fa-bars"></i> Show all</a>
                     </div>
 
-                    <table id="notestable">
-                        <thead>
-                            <tr>
-                                <th class="NoSort">&nbsp;</th>
-                                <th class="anti-the">Title</th>
-                                <th>Note</th>
-                                <th>Date</th>
-                                <th>Set by</th>
-                                <th>Status</th>
-                                <th class="NoSort noExport">Actions</th>
-                            </tr>
-                        </thead>
-                        <tbody>
-                            [% FOREACH note IN notes %]
+                    <div class="page-section">
+                        <table id="notestable">
+                            <thead>
                                 <tr>
-                                    <td><input type="checkbox" name="issue_ids" value="[% note.issue_id | html %]"></td>
-                                    <td>[% note.item.biblio.title | html %] - [% note.item.biblio.author | html %] (<a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% note.item.biblionumber | uri %]">[% note.item.barcode | html %]</a>)</td>
-                                    <td>[% note.note | html %]</td>
-                                    <td data-order="[% note.notedate | html %]">[% note.notedate | $KohaDates %]</td>
-                                    <td>[% INCLUDE 'patron-title.inc' patron => note.patron hide_patron_infos_if_needed=1 %]</td>
-                                    <td class="seen[% note.noteseen | html %]">
-                                        [% IF ( note.noteseen == 0 ) %]
-                                            <span id="status_[% note.issue_id | html %]">Not seen</span>
-                                        [% ELSIF ( note.noteseen == 1 ) %]
-                                            <span id="status_[% note.issue_id | html %]">Seen</span>
-                                        [% END %]
-                                    </td>
-                                    <td class="actions">
-                                        [% IF ( note.noteseen == 1 ) %]
-                                            <button name="seen" data-issue_id="[% note.issue_id | html %]" class="seen btn btn-default btn-xs" disabled="disabled"><i class="fa fa-eye"></i> Mark seen</button> <button name="notseen" data-issue_id="[% note.issue_id | html %]" class="notseen btn btn-default btn-xs"><i class="fa fa-eye-slash"></i> Mark not seen</button>
-                                        [% ELSIF ( note.noteseen == 0 ) %]
-                                            <button name="seen" data-issue_id="[% note.issue_id | html %]" class="seen btn btn-default btn-xs"><i class="fa fa-eye"></i> Mark seen</button> <button name="notseen" data-issue_id="[% note.issue_id | html %]" class="notseen btn btn-default btn-xs" disabled="disabled"><i class="fa fa-eye-slash"></i> Mark not seen</button>
-                                        [% END %]
-                                    </td>
+                                    <th class="NoSort">&nbsp;</th>
+                                    <th class="anti-the">Title</th>
+                                    <th>Note</th>
+                                    <th>Date</th>
+                                    <th>Set by</th>
+                                    <th>Status</th>
+                                    <th class="NoSort noExport">Actions</th>
                                 </tr>
-                            [% END %]
-                        </tbody>
-                    </table>
-
+                            </thead>
+                            <tbody>
+                                [% FOREACH note IN notes %]
+                                    <tr>
+                                        <td><input type="checkbox" name="issue_ids" value="[% note.issue_id | html %]"></td>
+                                        <td>[% note.item.biblio.title | html %] - [% note.item.biblio.author | html %] (<a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% note.item.biblionumber | uri %]">[% note.item.barcode | html %]</a>)</td>
+                                        <td>[% note.note | html %]</td>
+                                        <td data-order="[% note.notedate | html %]">[% note.notedate | $KohaDates %]</td>
+                                        <td>[% INCLUDE 'patron-title.inc' patron => note.patron hide_patron_infos_if_needed=1 %]</td>
+                                        <td class="seen[% note.noteseen | html %]">
+                                            [% IF ( note.noteseen == 0 ) %]
+                                                <span id="status_[% note.issue_id | html %]">Not seen</span>
+                                            [% ELSIF ( note.noteseen == 1 ) %]
+                                                <span id="status_[% note.issue_id | html %]">Seen</span>
+                                            [% END %]
+                                        </td>
+                                        <td class="actions">
+                                            [% IF ( note.noteseen == 1 ) %]
+                                                <button name="seen" data-issue_id="[% note.issue_id | html %]" class="seen btn btn-default btn-xs" disabled="disabled"><i class="fa fa-eye"></i> Mark seen</button> <button name="notseen" data-issue_id="[% note.issue_id | html %]" class="notseen btn btn-default btn-xs"><i class="fa fa-eye-slash"></i> Mark not seen</button>
+                                            [% ELSIF ( note.noteseen == 0 ) %]
+                                                <button name="seen" data-issue_id="[% note.issue_id | html %]" class="seen btn btn-default btn-xs"><i class="fa fa-eye"></i> Mark seen</button> <button name="notseen" data-issue_id="[% note.issue_id | html %]" class="notseen btn btn-default btn-xs" disabled="disabled"><i class="fa fa-eye-slash"></i> Mark not seen</button>
+                                            [% END %]
+                                        </td>
+                                    </tr>
+                                [% END %]
+                            </tbody>
+                        </table>
+                    </div>
                 </form>
 
             [% ELSE %]
-- 
2.39.5