]> git.koha-community.org Git - koha.git/commit
Bug 29115: Fix syntax errors in club hold functionality
authorJoonas Kylmälä <joonas.kylmala@iki.fi>
Sun, 26 Sep 2021 15:36:45 +0000 (15:36 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Sat, 11 Dec 2021 07:33:17 +0000 (21:33 -1000)
commit1eb6a02c2f1265cef30788f141efd527eaff58d5
tree1d2b9c2a7b400508aee2aaa02ca4371609366143
parent68502d183f93ee6016b1cfdcaf518bce07523aba
Bug 29115: Fix syntax errors in club hold functionality

The code didn't previously correctly do the checks for patron
debarment status and whether the patron has fees, this caused the
intended warnings messages to not appear when they should have.

To test:
 1) Create a new club and add a patron to it who has manual debarment
    and a manual charge of over $5 (more than the maxoutstanding syspref).
 2) Try to create a new club hold for the previously created club and
    notice no warnings are listed for the patron.
 3) Apply patch
 4) Try to create now the club hold again and notice the warnings
    being shown in the hold page.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
reserve/request.pl