From 00cf5afd52fbe0679b87d4f1ba0d76d3892f5069 Mon Sep 17 00:00:00 2001
From: Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se>
Date: Wed, 25 Nov 2020 07:45:39 +0000
Subject: [PATCH] Bug 27085: Corrections in overdue_notices.pl help text

-library      <branchname>     only deal with overdues from this library (repeatable : several libraries can be given)
Should be <branchcode>

Help text should also be proper sentences.

To test:
0) Run misc/cronjobs/overdue_notices.pl -h
1) Check that the text is now:
   -library      <branchcode>     Only deal with overdues from this library.
2) Check that the rest of the help text are proper sentences,
   with leading capital letter and punctuation.
3) Sign off.

Sponsored-by: Lunds Universitetsbibliotek
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 1ad7d034e65d0b518335086345f2f533d1898c56)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 misc/cronjobs/overdue_notices.pl | 34 +++++++++++++++++---------------
 1 file changed, 18 insertions(+), 16 deletions(-)

diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl
index 591feea145..2cad47a0d8 100755
--- a/misc/cronjobs/overdue_notices.pl
+++ b/misc/cronjobs/overdue_notices.pl
@@ -58,23 +58,25 @@ overdue_notices.pl
   [ -email <email_type> ... ]
 
  Options:
-   -help                          brief help message
-   -man                           full documentation
-   -v                             verbose
-   -n                             No email will be sent
-   -max          <days>           maximum days overdue to deal with
-   -library      <branchname>     only deal with overdues from this library (repeatable : several libraries can be given)
-   -csv          <filename>       populate CSV file
-   -html         <directory>      Output html to a file in the given directory
-   -text         <directory>      Output plain text to a file in the given directory
-   -itemscontent <list of fields> item information in templates
-   -borcat       <categorycode>   category code that must be included
-   -borcatout    <categorycode>   category code that must be excluded
-   -t                             only include triggered overdues
+   -help                          Brief help message.
+   -man                           Full documentation.
+   -v                             Verbose mode.
+   -n                             No email will be sent.
+   -max          <days>           Maximum days overdue to deal with.
+   -library      <branchcode>     Only deal with overdues from this library.
+                                  (repeatable : several libraries can be given)
+   -csv          <filename>       Populate CSV file.
+   -html         <directory>      Output html to a file in the given directory.
+   -text         <directory>      Output plain text to a file in the given directory.
+   -itemscontent <list of fields> Item information in templates.
+   -borcat       <categorycode>   Category code that must be included.
+   -borcatout    <categorycode>   Category code that must be excluded.
+   -t                             Only include triggered overdues.
    --test                         Run in test mode. No changes will be made on the DB.
-   -list-all                      list all overdues
-   -date         <yyyy-mm-dd>     emulate overdues run for this date
-   -email        <email_type>     type of email that will be used. Can be 'email', 'emailpro' or 'B_email'. Repeatable.
+   -list-all                      List all overdues.
+   -date         <yyyy-mm-dd>     Emulate overdues run for this date.
+   -email        <email_type>     Type of email that will be used.
+                                  Can be 'email', 'emailpro' or 'B_email'. Repeatable.
 
 =head1 OPTIONS
 
-- 
2.39.5