From 432d7332c4dd9f49f89ec9d8ad6643c2fa0e46ab Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Tue, 6 Apr 2021 08:16:37 -0300 Subject: [PATCH] Bug 28017: (follow-up) Fix Letters.t Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit 789a7a863426c7887055095ca58e09fd46f67972) Signed-off-by: Fridolin Somers --- t/db_dependent/Letters.t | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/t/db_dependent/Letters.t b/t/db_dependent/Letters.t index 3ba3361d28..35eb84d32e 100755 --- a/t/db_dependent/Letters.t +++ b/t/db_dependent/Letters.t @@ -962,7 +962,7 @@ subtest 'Test limit parameter for SendQueuedMessages' => sub { subtest 'Test message_id parameter for SendQueuedMessages' => sub { - plan tests => 5; + plan tests => 6; my $dbh = C4::Context->dbh; @@ -987,7 +987,7 @@ subtest 'Test message_id parameter for SendQueuedMessages' => sub { 'borrowernumber' => $borrowernumber, 'to_address' => 'to@example.org', 'message_transport_type' => 'email', - 'from_address' => 'root@localhost' # invalid KohaAdminEmailAddress + 'from_address' => 'root@localhost.' # invalid KohaAdminEmailAddress }; my $message_id = C4::Letters::EnqueueLetter($my_message); throws_ok { @@ -1000,7 +1000,9 @@ subtest 'Test message_id parameter for SendQueuedMessages' => sub { $my_message->{from_address} = 'root@example.org'; # valid KohaAdminEmailAddress $message_id = C4::Letters::EnqueueLetter($my_message); - C4::Letters::SendQueuedMessages( { message_id => $message_id } ); + warning_like { C4::Letters::SendQueuedMessages( { message_id => $message_id } ); } + qr|Fake send_or_die|, + "SendQueuedMessages is using the mocked send_or_die routine"; $message_1 = C4::Letters::GetMessage($message_1->{message_id}); my $message_2 = C4::Letters::GetMessage($message_id); is( $message_1->{status}, 'pending', 'Message 1 status is unchanged' ); # Must be 'failed' -- 2.39.5