From c66668b16cd8949e46f88a104870298ba013ed82 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 20 Jul 2021 10:30:30 +0200
Subject: [PATCH] Bug 28769: Remove tabloop from cataloguing plugins

There is a "tabloop" variable that is passed from the add item form logic to the cataloguing plugins.
But there is confusion, sometimes it's an iterator ($i) and sometimes (batchMod.pl) an array.

Actually this tabloop variable is never used from cataloguing plugins, we should remove it.

Test plan:
Read the code and confirm the above.
You can also test a couple of plugins and confirm that they are still
working.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 C4/Items.pm                                        |  2 +-
 Koha/FrameworkPlugin.pm                            |  4 ++--
 authorities/authorities.pl                         | 14 +++++++-------
 cataloguing/addbiblio.pl                           | 12 ++++++------
 cataloguing/additem.pl                             |  6 +++---
 cataloguing/value_builder/unimarc_field_010.pl     |  2 +-
 cataloguing/value_builder/unimarc_field_100.pl     |  2 +-
 .../value_builder/unimarc_field_100_authorities.pl |  2 +-
 cataloguing/value_builder/unimarc_field_105.pl     |  2 +-
 cataloguing/value_builder/unimarc_field_106.pl     |  2 +-
 cataloguing/value_builder/unimarc_field_110.pl     |  2 +-
 cataloguing/value_builder/unimarc_field_115a.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_115b.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_116.pl     |  2 +-
 cataloguing/value_builder/unimarc_field_117.pl     |  2 +-
 cataloguing/value_builder/unimarc_field_120.pl     |  2 +-
 cataloguing/value_builder/unimarc_field_121a.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_121b.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_122.pl     |  2 +-
 cataloguing/value_builder/unimarc_field_123a.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_123d.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_123e.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_123f.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_123g.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_123i.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_123j.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_124.pl     |  2 +-
 cataloguing/value_builder/unimarc_field_124a.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_124b.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_124c.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_124d.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_124e.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_124f.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_124g.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_125.pl     |  2 +-
 cataloguing/value_builder/unimarc_field_125a.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_125b.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_126.pl     |  2 +-
 cataloguing/value_builder/unimarc_field_126a.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_126b.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_127.pl     |  2 +-
 cataloguing/value_builder/unimarc_field_128a.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_128b.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_128c.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_130.pl     |  2 +-
 cataloguing/value_builder/unimarc_field_135a.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_140.pl     |  2 +-
 cataloguing/value_builder/unimarc_field_141.pl     |  2 +-
 cataloguing/value_builder/unimarc_field_210c.pl    |  2 +-
 .../value_builder/unimarc_field_210c_bis.pl        |  2 +-
 cataloguing/value_builder/unimarc_field_225a.pl    |  2 +-
 .../value_builder/unimarc_field_225a_bis.pl        |  2 +-
 cataloguing/value_builder/unimarc_field_4XX.pl     |  4 ++--
 cataloguing/value_builder/unimarc_field_686a.pl    |  2 +-
 cataloguing/value_builder/unimarc_field_700-4.pl   |  2 +-
 cataloguing/value_builder/unimarc_leader.pl        |  2 +-
 t/db_dependent/FrameworkPlugin.t                   |  2 +-
 tools/batchMod.pl                                  |  2 +-
 58 files changed, 73 insertions(+), 73 deletions(-)

diff --git a/C4/Items.pm b/C4/Items.pm
index 1fa72d21c2..13c7f579f4 100644
--- a/C4/Items.pm
+++ b/C4/Items.pm
@@ -1757,7 +1757,7 @@ sub PrepareItemrecordDisplay {
                         name => $subfield->{value_builder},
                         item_style => 1,
                     });
-                    my $pars = { dbh => $dbh, record => undef, tagslib =>$tagslib, id => $subfield_data{id}, tabloop => undef };
+                    my $pars = { dbh => $dbh, record => undef, tagslib =>$tagslib, id => $subfield_data{id} };
                     $plugin->build( $pars );
                     if ( $itemrecord and my $field = $itemrecord->field($tag) ) {
                         $defaultvalue = $field->subfield($subfield->{subfield}) || q{};
diff --git a/Koha/FrameworkPlugin.pm b/Koha/FrameworkPlugin.pm
index a50328a1f6..2331bfa6b3 100644
--- a/Koha/FrameworkPlugin.pm
+++ b/Koha/FrameworkPlugin.pm
@@ -155,7 +155,7 @@ sub new {
     Generate html and javascript by calling the builder sub of the plugin.
 
     Params is a hashref supporting keys: id (=html id for the input field),
-    record (MARC record or undef), dbh (database handle), tagslib, tabloop.
+    record (MARC record or undef), dbh (database handle), tagslib.
     Note that some of these parameters are not used in most (if not all)
     plugins and may be obsoleted in the future (kept for now to provide
     backward compatibility).
@@ -276,7 +276,7 @@ sub _generate_js {
 
     my @params = $self->{oldschool}//0 ?
         ( $params->{dbh}, $params->{record}, $params->{tagslib},
-            $params->{id}, $params->{tabloop} ):
+            $params->{id} ):
         ( $params );
     my @rv = &$sub( @params );
     return $self->_error( 'Builder sub failed: ' . $@ ) if $@;
diff --git a/authorities/authorities.pl b/authorities/authorities.pl
index 229dc27660..fc4ae1a200 100755
--- a/authorities/authorities.pl
+++ b/authorities/authorities.pl
@@ -133,8 +133,8 @@ builds the <input ...> entry for a subfield.
 =cut
 
 sub create_input {
-    my ( $tag, $subfield, $value, $index_tag, $tabloop, $rec, $authorised_values_sth,$cgi ) = @_;
-    
+    my ( $tag, $subfield, $value, $index_tag, $rec, $authorised_values_sth,$cgi ) = @_;
+
     my $index_subfield = CreateKey(); # create a specifique key for each subfield
 
     # determine maximum length; 9999 bytes per ISO 2709 except for leader and MARC21 008
@@ -213,7 +213,7 @@ sub create_input {
             name => $tagslib->{$tag}->{$subfield}->{'value_builder'},
         });
         my $pars=  { dbh => $dbh, record => $rec, tagslib =>$tagslib,
-            id => $subfield_data{id}, tabloop => $tabloop };
+            id => $subfield_data{id} };
         $plugin->build( $pars );
         if( !$plugin->errstr ) {
             $subfield_data{marc_value} = {
@@ -410,7 +410,7 @@ sub build_tabs {
                         push(
                             @subfields_data,
                             &create_input(
-                                $tag, $subfield, $value, $index_tag, $tabloop, $record,
+                                $tag, $subfield, $value, $index_tag, $record,
                                 $authorised_values_sth,$input
                             )
                         );
@@ -426,7 +426,7 @@ sub build_tabs {
                             push(
                                 @subfields_data,
                                 &create_input(
-                                    $tag, $subfield, $value, $index_tag, $tabloop,
+                                    $tag, $subfield, $value, $index_tag,
                                     $record, $authorised_values_sth,$input
                                 )
                             );
@@ -444,7 +444,7 @@ sub build_tabs {
                         push(
                             @subfields_data,
                             &create_input(
-                                $tag, $subfield, '', $index_tag, $tabloop, $record,
+                                $tag, $subfield, '', $index_tag, $record,
                                 $authorised_values_sth,$input
                             )
                         );
@@ -486,7 +486,7 @@ sub build_tabs {
                     push(
                         @subfields_data,
                         &create_input(
-                            $tag, $subfield->{subfield}, '', $index_tag, $tabloop, $record,
+                            $tag, $subfield->{subfield}, '', $index_tag, $record,
                             $authorised_values_sth,$input
                         )
                     );
diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl
index f1a13bed7b..903b30b26f 100755
--- a/cataloguing/addbiblio.pl
+++ b/cataloguing/addbiblio.pl
@@ -283,7 +283,7 @@ sub GetMandatoryFieldZ3950 {
 =cut
 
 sub create_input {
-    my ( $tag, $subfield, $value, $index_tag, $tabloop, $rec, $authorised_values_sth,$cgi ) = @_;
+    my ( $tag, $subfield, $value, $index_tag, $rec, $authorised_values_sth,$cgi ) = @_;
     
     my $index_subfield = CreateKey(); # create a specifique key for each subfield
 
@@ -394,7 +394,7 @@ sub create_input {
             name => $tagslib->{$tag}->{$subfield}->{'value_builder'},
         });
         my $pars= { dbh => $dbh, record => $rec, tagslib => $tagslib,
-            id => $subfield_data{id}, tabloop => $tabloop };
+            id => $subfield_data{id} };
         $plugin->build( $pars );
         if( !$plugin->errstr ) {
             $subfield_data{marc_value} = {
@@ -567,7 +567,7 @@ sub build_tabs {
                         push(
                             @subfields_data,
                             &create_input(
-                                $tag, $subfield, $value, $index_tag, $tabloop, $record,
+                                $tag, $subfield, $value, $index_tag, $record,
                                 $authorised_values_sth,$input
                             )
                         );
@@ -582,7 +582,7 @@ sub build_tabs {
                             push(
                                 @subfields_data,
                                 &create_input(
-                                    $tag, $subfield, $value, $index_tag, $tabloop,
+                                    $tag, $subfield, $value, $index_tag,
                                     $record, $authorised_values_sth,$input
                                 )
                             );
@@ -612,7 +612,7 @@ sub build_tabs {
                         push(
                             @subfields_data,
                             &create_input(
-                                $tag, $subfield, '', $index_tag, $tabloop, $record,
+                                $tag, $subfield, '', $index_tag, $record,
                                 $authorised_values_sth,$input
                             )
                         );
@@ -668,7 +668,7 @@ sub build_tabs {
 			push(
                         @subfields_data,
                         &create_input(
-                            $tag, $subfield->{subfield}, '', $index_tag, $tabloop, $record,
+                            $tag, $subfield->{subfield}, '', $index_tag, $record,
                             $authorised_values_sth,$input
                         )
                     );
diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl
index 2dd4ad0a84..bdccd48ad1 100755
--- a/cataloguing/additem.pl
+++ b/cataloguing/additem.pl
@@ -59,7 +59,7 @@ use List::MoreUtils qw( any uniq );
 our $dbh = C4::Context->dbh;
 
 sub generate_subfield_form {
-        my ($tag, $subfieldtag, $value, $tagslib,$subfieldlib, $branches, $biblionumber, $temp, $subfields, $i, $restrictededition, $item) = @_;
+        my ($tag, $subfieldtag, $value, $tagslib,$subfieldlib, $branches, $biblionumber, $temp, $i, $restrictededition, $item) = @_;
   
         my $frameworkcode = &GetFrameworkCode($biblionumber);
 
@@ -241,7 +241,7 @@ sub generate_subfield_form {
                 item_style => 1,
             });
             my $pars=  { dbh => $dbh, record => $temp, tagslib =>$tagslib,
-                id => $subfield_data{id}, tabloop => $subfields };
+                id => $subfield_data{id} };
             $plugin->build( $pars );
             if( !$plugin->errstr ) {
                 my $class= 'buttonDot'. ( $plugin->noclick? ' disabled': '' );
@@ -889,7 +889,7 @@ foreach my $tag ( keys %{$tagslib} ) {
                 $value,                      $tagslib,
                 $subfield,                   $libraries,
                 $biblionumber,               $temp,
-                \@subfields,                 $i,
+                $i,
                 $restrictededition,          $current_item,
             );
             push @subfields, $subfield_data;
diff --git a/cataloguing/value_builder/unimarc_field_010.pl b/cataloguing/value_builder/unimarc_field_010.pl
index 56a5c5c3ce..00f5eb05b1 100755
--- a/cataloguing/value_builder/unimarc_field_010.pl
+++ b/cataloguing/value_builder/unimarc_field_010.pl
@@ -26,7 +26,7 @@ use C4::Output qw( output_html_with_http_headers );
 
 
 sub plugin_javascript {
-    my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+    my ($dbh,$record,$tagslib,$field_number) = @_;
     my $res="
     <script>
         function Blur$field_number() {
diff --git a/cataloguing/value_builder/unimarc_field_100.pl b/cataloguing/value_builder/unimarc_field_100.pl
index ef2e08bb9b..df4c970291 100755
--- a/cataloguing/value_builder/unimarc_field_100.pl
+++ b/cataloguing/value_builder/unimarc_field_100.pl
@@ -30,7 +30,7 @@ use C4::Output qw( output_html_with_http_headers );
 
 
 sub plugin_javascript {
-    my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
+    my ( $dbh, $record, $tagslib, $field_number ) = @_;
     my $res           = "
         <script>
             function Clic$field_number(i) {
diff --git a/cataloguing/value_builder/unimarc_field_100_authorities.pl b/cataloguing/value_builder/unimarc_field_100_authorities.pl
index ff7aa576f3..f15185c430 100755
--- a/cataloguing/value_builder/unimarc_field_100_authorities.pl
+++ b/cataloguing/value_builder/unimarc_field_100_authorities.pl
@@ -27,7 +27,7 @@ use C4::Output qw( output_html_with_http_headers );
 
 
 sub plugin_javascript {
-    my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
+    my ( $dbh, $record, $tagslib, $field_number ) = @_;
     my $res           = "
         <script>
             function Clic$field_number(i) {
diff --git a/cataloguing/value_builder/unimarc_field_105.pl b/cataloguing/value_builder/unimarc_field_105.pl
index e239de664e..f0ff7f2dd8 100755
--- a/cataloguing/value_builder/unimarc_field_105.pl
+++ b/cataloguing/value_builder/unimarc_field_105.pl
@@ -30,7 +30,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-    my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+    my ($dbh,$record,$tagslib,$field_number) = @_;
     my $res="
     <script>
         function Clic$field_number() {
diff --git a/cataloguing/value_builder/unimarc_field_106.pl b/cataloguing/value_builder/unimarc_field_106.pl
index 488b6ba889..7b91dd4410 100755
--- a/cataloguing/value_builder/unimarc_field_106.pl
+++ b/cataloguing/value_builder/unimarc_field_106.pl
@@ -28,7 +28,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= "106".(int(rand(100000))+1);
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_110.pl b/cataloguing/value_builder/unimarc_field_110.pl
index 79b173aca7..b3e88e2c20 100755
--- a/cataloguing/value_builder/unimarc_field_110.pl
+++ b/cataloguing/value_builder/unimarc_field_110.pl
@@ -30,7 +30,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-    my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+    my ($dbh,$record,$tagslib,$field_number) = @_;
     my $res="
     <script>
     function Clic$field_number() {
diff --git a/cataloguing/value_builder/unimarc_field_115a.pl b/cataloguing/value_builder/unimarc_field_115a.pl
index c741a8fa44..fc0223a3e6 100755
--- a/cataloguing/value_builder/unimarc_field_115a.pl
+++ b/cataloguing/value_builder/unimarc_field_115a.pl
@@ -29,7 +29,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-    my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
+    my ( $dbh, $record, $tagslib, $field_number ) = @_;
     my $res = "
     <script>
     function Clic$field_number(i) {
diff --git a/cataloguing/value_builder/unimarc_field_115b.pl b/cataloguing/value_builder/unimarc_field_115b.pl
index 55adaf2ca1..901e73eb3e 100755
--- a/cataloguing/value_builder/unimarc_field_115b.pl
+++ b/cataloguing/value_builder/unimarc_field_115b.pl
@@ -29,7 +29,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-    my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
+    my ( $dbh, $record, $tagslib, $field_number ) = @_;
     my $res = "
 <script>
 function Clic$field_number() {
diff --git a/cataloguing/value_builder/unimarc_field_116.pl b/cataloguing/value_builder/unimarc_field_116.pl
index 858ab48d8a..8781a5da2f 100755
--- a/cataloguing/value_builder/unimarc_field_116.pl
+++ b/cataloguing/value_builder/unimarc_field_116.pl
@@ -29,7 +29,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-    my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
+    my ( $dbh, $record, $tagslib, $field_number ) = @_;
     my $res = "
 <script>
 function Clic$field_number(i) {
diff --git a/cataloguing/value_builder/unimarc_field_117.pl b/cataloguing/value_builder/unimarc_field_117.pl
index 4d4223c5c2..9286826145 100755
--- a/cataloguing/value_builder/unimarc_field_117.pl
+++ b/cataloguing/value_builder/unimarc_field_117.pl
@@ -29,7 +29,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $res="
 <script>
 function Clic$field_number(i) {
diff --git a/cataloguing/value_builder/unimarc_field_120.pl b/cataloguing/value_builder/unimarc_field_120.pl
index 1450a5e35b..4c4d06139d 100755
--- a/cataloguing/value_builder/unimarc_field_120.pl
+++ b/cataloguing/value_builder/unimarc_field_120.pl
@@ -30,7 +30,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name=$field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_121a.pl b/cataloguing/value_builder/unimarc_field_121a.pl
index 0da0894d42..e1967e38ca 100755
--- a/cataloguing/value_builder/unimarc_field_121a.pl
+++ b/cataloguing/value_builder/unimarc_field_121a.pl
@@ -29,7 +29,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_121b.pl b/cataloguing/value_builder/unimarc_field_121b.pl
index bc5bf1ec95..bcdc22aac0 100755
--- a/cataloguing/value_builder/unimarc_field_121b.pl
+++ b/cataloguing/value_builder/unimarc_field_121b.pl
@@ -27,7 +27,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_122.pl b/cataloguing/value_builder/unimarc_field_122.pl
index 0b326c443c..ecedc74cc2 100755
--- a/cataloguing/value_builder/unimarc_field_122.pl
+++ b/cataloguing/value_builder/unimarc_field_122.pl
@@ -27,7 +27,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_123a.pl b/cataloguing/value_builder/unimarc_field_123a.pl
index cf74e41029..3d3fa4f56f 100755
--- a/cataloguing/value_builder/unimarc_field_123a.pl
+++ b/cataloguing/value_builder/unimarc_field_123a.pl
@@ -27,7 +27,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_123d.pl b/cataloguing/value_builder/unimarc_field_123d.pl
index 9fb25ffb2e..50865fb2eb 100755
--- a/cataloguing/value_builder/unimarc_field_123d.pl
+++ b/cataloguing/value_builder/unimarc_field_123d.pl
@@ -28,7 +28,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_123e.pl b/cataloguing/value_builder/unimarc_field_123e.pl
index 9fb25ffb2e..50865fb2eb 100755
--- a/cataloguing/value_builder/unimarc_field_123e.pl
+++ b/cataloguing/value_builder/unimarc_field_123e.pl
@@ -28,7 +28,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_123f.pl b/cataloguing/value_builder/unimarc_field_123f.pl
index 660d601df6..4fb190e52a 100755
--- a/cataloguing/value_builder/unimarc_field_123f.pl
+++ b/cataloguing/value_builder/unimarc_field_123f.pl
@@ -28,7 +28,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_123g.pl b/cataloguing/value_builder/unimarc_field_123g.pl
index 9fb25ffb2e..50865fb2eb 100755
--- a/cataloguing/value_builder/unimarc_field_123g.pl
+++ b/cataloguing/value_builder/unimarc_field_123g.pl
@@ -28,7 +28,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_123i.pl b/cataloguing/value_builder/unimarc_field_123i.pl
index 51d6477673..a62c23ab37 100755
--- a/cataloguing/value_builder/unimarc_field_123i.pl
+++ b/cataloguing/value_builder/unimarc_field_123i.pl
@@ -28,7 +28,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_123j.pl b/cataloguing/value_builder/unimarc_field_123j.pl
index 7ca7f07d3a..aa2a3c31e0 100755
--- a/cataloguing/value_builder/unimarc_field_123j.pl
+++ b/cataloguing/value_builder/unimarc_field_123j.pl
@@ -28,7 +28,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
     <script>
diff --git a/cataloguing/value_builder/unimarc_field_124.pl b/cataloguing/value_builder/unimarc_field_124.pl
index cfcb8d7c7f..82ab72d4f4 100755
--- a/cataloguing/value_builder/unimarc_field_124.pl
+++ b/cataloguing/value_builder/unimarc_field_124.pl
@@ -28,7 +28,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_124a.pl b/cataloguing/value_builder/unimarc_field_124a.pl
index 9d14d7a9fd..ef2e7dccb7 100755
--- a/cataloguing/value_builder/unimarc_field_124a.pl
+++ b/cataloguing/value_builder/unimarc_field_124a.pl
@@ -28,7 +28,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_124b.pl b/cataloguing/value_builder/unimarc_field_124b.pl
index e004bddfd8..9008ea673c 100755
--- a/cataloguing/value_builder/unimarc_field_124b.pl
+++ b/cataloguing/value_builder/unimarc_field_124b.pl
@@ -28,7 +28,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_124c.pl b/cataloguing/value_builder/unimarc_field_124c.pl
index 19f8a130ab..3433ea9a93 100755
--- a/cataloguing/value_builder/unimarc_field_124c.pl
+++ b/cataloguing/value_builder/unimarc_field_124c.pl
@@ -28,7 +28,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_124d.pl b/cataloguing/value_builder/unimarc_field_124d.pl
index a100375532..e65d93eaa2 100755
--- a/cataloguing/value_builder/unimarc_field_124d.pl
+++ b/cataloguing/value_builder/unimarc_field_124d.pl
@@ -28,7 +28,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_124e.pl b/cataloguing/value_builder/unimarc_field_124e.pl
index 73226113ae..11d1aabfa3 100755
--- a/cataloguing/value_builder/unimarc_field_124e.pl
+++ b/cataloguing/value_builder/unimarc_field_124e.pl
@@ -28,7 +28,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_124f.pl b/cataloguing/value_builder/unimarc_field_124f.pl
index 8a0836a7a5..96df17be7a 100755
--- a/cataloguing/value_builder/unimarc_field_124f.pl
+++ b/cataloguing/value_builder/unimarc_field_124f.pl
@@ -28,7 +28,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_124g.pl b/cataloguing/value_builder/unimarc_field_124g.pl
index 3f40b1e9e9..4dfe3a7d9f 100755
--- a/cataloguing/value_builder/unimarc_field_124g.pl
+++ b/cataloguing/value_builder/unimarc_field_124g.pl
@@ -28,7 +28,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_125.pl b/cataloguing/value_builder/unimarc_field_125.pl
index 4eb86d9cbf..fa31200861 100755
--- a/cataloguing/value_builder/unimarc_field_125.pl
+++ b/cataloguing/value_builder/unimarc_field_125.pl
@@ -34,7 +34,7 @@ plugin_parameters : other parameters added when the plugin is called by the dopo
 =cut
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_125a.pl b/cataloguing/value_builder/unimarc_field_125a.pl
index 947050f38d..c4585d7e24 100755
--- a/cataloguing/value_builder/unimarc_field_125a.pl
+++ b/cataloguing/value_builder/unimarc_field_125a.pl
@@ -28,7 +28,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
     <script>
diff --git a/cataloguing/value_builder/unimarc_field_125b.pl b/cataloguing/value_builder/unimarc_field_125b.pl
index d556949835..2429d3e48b 100755
--- a/cataloguing/value_builder/unimarc_field_125b.pl
+++ b/cataloguing/value_builder/unimarc_field_125b.pl
@@ -29,7 +29,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_126.pl b/cataloguing/value_builder/unimarc_field_126.pl
index cfcb8d7c7f..82ab72d4f4 100755
--- a/cataloguing/value_builder/unimarc_field_126.pl
+++ b/cataloguing/value_builder/unimarc_field_126.pl
@@ -28,7 +28,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_126a.pl b/cataloguing/value_builder/unimarc_field_126a.pl
index f5ed0f7f03..d1cfd84c4c 100755
--- a/cataloguing/value_builder/unimarc_field_126a.pl
+++ b/cataloguing/value_builder/unimarc_field_126a.pl
@@ -29,7 +29,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_126b.pl b/cataloguing/value_builder/unimarc_field_126b.pl
index 1c261bcc80..79778cfe44 100755
--- a/cataloguing/value_builder/unimarc_field_126b.pl
+++ b/cataloguing/value_builder/unimarc_field_126b.pl
@@ -28,7 +28,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_127.pl b/cataloguing/value_builder/unimarc_field_127.pl
index 9845a547ed..85adba0dad 100755
--- a/cataloguing/value_builder/unimarc_field_127.pl
+++ b/cataloguing/value_builder/unimarc_field_127.pl
@@ -28,7 +28,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_128a.pl b/cataloguing/value_builder/unimarc_field_128a.pl
index 4b6ad8e90a..9f235e1e5d 100755
--- a/cataloguing/value_builder/unimarc_field_128a.pl
+++ b/cataloguing/value_builder/unimarc_field_128a.pl
@@ -28,7 +28,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_128b.pl b/cataloguing/value_builder/unimarc_field_128b.pl
index 1c860bf3b9..7d2e215fb8 100755
--- a/cataloguing/value_builder/unimarc_field_128b.pl
+++ b/cataloguing/value_builder/unimarc_field_128b.pl
@@ -29,7 +29,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_128c.pl b/cataloguing/value_builder/unimarc_field_128c.pl
index 56ce4a1d68..a0ff9ddd4e 100755
--- a/cataloguing/value_builder/unimarc_field_128c.pl
+++ b/cataloguing/value_builder/unimarc_field_128c.pl
@@ -28,7 +28,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_130.pl b/cataloguing/value_builder/unimarc_field_130.pl
index 19db6d6321..411eb80a8e 100755
--- a/cataloguing/value_builder/unimarc_field_130.pl
+++ b/cataloguing/value_builder/unimarc_field_130.pl
@@ -30,7 +30,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_135a.pl b/cataloguing/value_builder/unimarc_field_135a.pl
index 050f8ec820..db5bf3c8b0 100755
--- a/cataloguing/value_builder/unimarc_field_135a.pl
+++ b/cataloguing/value_builder/unimarc_field_135a.pl
@@ -29,7 +29,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_140.pl b/cataloguing/value_builder/unimarc_field_140.pl
index 467ecb412a..a5b303158b 100755
--- a/cataloguing/value_builder/unimarc_field_140.pl
+++ b/cataloguing/value_builder/unimarc_field_140.pl
@@ -30,7 +30,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_141.pl b/cataloguing/value_builder/unimarc_field_141.pl
index 907f3e39af..a7a28ea306 100755
--- a/cataloguing/value_builder/unimarc_field_141.pl
+++ b/cataloguing/value_builder/unimarc_field_141.pl
@@ -28,7 +28,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_210c.pl b/cataloguing/value_builder/unimarc_field_210c.pl
index e09e259c2e..c9e1ebbcf8 100755
--- a/cataloguing/value_builder/unimarc_field_210c.pl
+++ b/cataloguing/value_builder/unimarc_field_210c.pl
@@ -31,7 +31,7 @@ use C4::AuthoritiesMarc qw( GetAuthority SearchAuthorities );
 ###TODO To rewrite in order to use SearchAuthorities
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 #---- build editors list.
 #---- the editor list is built from the "EDITORS" thesaurus
diff --git a/cataloguing/value_builder/unimarc_field_210c_bis.pl b/cataloguing/value_builder/unimarc_field_210c_bis.pl
index 5204ddd662..b558d520d2 100755
--- a/cataloguing/value_builder/unimarc_field_210c_bis.pl
+++ b/cataloguing/value_builder/unimarc_field_210c_bis.pl
@@ -48,7 +48,7 @@ use C4::Auth qw( get_template_and_user );
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-    my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
+    my ( $dbh, $record, $tagslib, $field_number ) = @_;
     my $function_name = $field_number;
     my $res           = "
     <script>
diff --git a/cataloguing/value_builder/unimarc_field_225a.pl b/cataloguing/value_builder/unimarc_field_225a.pl
index 761302cd23..31556ae506 100755
--- a/cataloguing/value_builder/unimarc_field_225a.pl
+++ b/cataloguing/value_builder/unimarc_field_225a.pl
@@ -56,7 +56,7 @@ plugin_parameters : other parameters added when the plugin is called by the dopo
 =cut
 
 sub plugin_javascript {
-    my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
+    my ( $dbh, $record, $tagslib, $field_number ) = @_;
     my $function_name = $field_number;
     my $res = "
     <script>
diff --git a/cataloguing/value_builder/unimarc_field_225a_bis.pl b/cataloguing/value_builder/unimarc_field_225a_bis.pl
index 5bfedad414..1ca62775a9 100755
--- a/cataloguing/value_builder/unimarc_field_225a_bis.pl
+++ b/cataloguing/value_builder/unimarc_field_225a_bis.pl
@@ -31,7 +31,7 @@ use C4::Context;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-    my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
+    my ( $dbh, $record, $tagslib, $field_number ) = @_;
     my $function_name = $field_number;
     my $res           = "
     <script>
diff --git a/cataloguing/value_builder/unimarc_field_4XX.pl b/cataloguing/value_builder/unimarc_field_4XX.pl
index db0bbd26ed..83dcaf3c8c 100755
--- a/cataloguing/value_builder/unimarc_field_4XX.pl
+++ b/cataloguing/value_builder/unimarc_field_4XX.pl
@@ -36,12 +36,12 @@ use Koha::SearchEngine;
 use Koha::SearchEngine::Search;
 
 sub plugin_parameters {
-    my ( $dbh, $record, $tagslib, $i, $tabloop ) = @_;
+    my ( $dbh, $record, $tagslib, $i ) = @_;
     return "";
 }
 
 sub plugin_javascript {
-    my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
+    my ( $dbh, $record, $tagslib, $field_number ) = @_;
     my $function_name = $field_number;
     my $res           = "
     <script>
diff --git a/cataloguing/value_builder/unimarc_field_686a.pl b/cataloguing/value_builder/unimarc_field_686a.pl
index 38a1e48513..d766b038c6 100755
--- a/cataloguing/value_builder/unimarc_field_686a.pl
+++ b/cataloguing/value_builder/unimarc_field_686a.pl
@@ -27,7 +27,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res  = "
 <script>
diff --git a/cataloguing/value_builder/unimarc_field_700-4.pl b/cataloguing/value_builder/unimarc_field_700-4.pl
index 895db7a1d2..0d083e9d39 100755
--- a/cataloguing/value_builder/unimarc_field_700-4.pl
+++ b/cataloguing/value_builder/unimarc_field_700-4.pl
@@ -29,7 +29,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res  = "
 <script>
diff --git a/cataloguing/value_builder/unimarc_leader.pl b/cataloguing/value_builder/unimarc_leader.pl
index 44d8c9319c..838f5a88f0 100755
--- a/cataloguing/value_builder/unimarc_leader.pl
+++ b/cataloguing/value_builder/unimarc_leader.pl
@@ -29,7 +29,7 @@ use C4::Search;
 use C4::Output qw( output_html_with_http_headers );
 
 sub plugin_javascript {
-    my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
+    my ( $dbh, $record, $tagslib, $field_number ) = @_;
     my $function_name = $field_number;
     my $res           = "
 <script>
diff --git a/t/db_dependent/FrameworkPlugin.t b/t/db_dependent/FrameworkPlugin.t
index 81afb48fe8..41baf49153 100755
--- a/t/db_dependent/FrameworkPlugin.t
+++ b/t/db_dependent/FrameworkPlugin.t
@@ -222,7 +222,7 @@ sub old01 {
 # includes a typical empty Clic function and plugin subroutine
     return mytempfile( <<'HERE'
 sub plugin_javascript {
-    my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+    my ($dbh,$record,$tagslib,$field_number) = @_;
     my $function_name = $field_number;
     my $res = "
 <script type=\"text/javascript\">
diff --git a/tools/batchMod.pl b/tools/batchMod.pl
index 16e0e1ac31..a753f72b00 100755
--- a/tools/batchMod.pl
+++ b/tools/batchMod.pl
@@ -532,7 +532,7 @@ foreach my $tag (sort keys %{$tagslib}) {
         });
         my $temp;
         my $pars= { dbh => $dbh, record => $temp, tagslib => $tagslib,
-            id => $subfield_data{id}, tabloop => \@loop_data };
+            id => $subfield_data{id} };
         $plugin->build( $pars );
         if( !$plugin->errstr ) {
             $subfield_data{marc_value} = {
-- 
2.39.5