From fc22fb308bdbfc6d1bda3448e966542f2828ad76 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 3 Aug 2020 13:09:54 +0200 Subject: [PATCH] Bug 26119: Enable patron's attribute edition when PatronSelfRegistrationVerifyByEmail There is no good reason remove the ability to edit patron's attributes if PatronSelfRegistrationVerifyByEmail is set. We cannot have them in the self-registration form (because we don't store patron's attributes during self-ref), but we can have them when a patron show/edit their information. Test plan: 0. Enable PatronSelfRegistrationVerifyByEmail and create patron's attributes that can be edited at the OPAC 1. Create a new patron using the self-reg feature => You don't have the ability to fill in the patron's attribute 2. Edit your personal details (OPAC) => Without this patch you still don't see the patron's attribute that can be edited at the OPAC => With this patch applied you can! 3. Notice the wording change on the "Modify patron attribute type" form and confirm it makes sense Signed-off-by: Sally Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart --- .../intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt index bd711ed68c..891698a206 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt @@ -117,7 +117,7 @@ [% ELSE %] [% END %] - Check to allow patrons to edit this attribute from their details page in the OPAC. (Requires above, does not work with PatronSelfRegistrationVerifyByEmail.) + Check to allow patrons to edit this attribute from their details page in the OPAC. (Requires above, does not work during self-registration.)
  • [% IF attribute_type AND attribute_type.staff_searchable %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt index 7acd45af30..645f53dd75 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt @@ -892,7 +892,7 @@ [% END %] - [% IF ( Koha.Preference('ExtendedPatronAttributes') && patron_attribute_classes.size && !Koha.Preference('PatronSelfRegistrationVerifyByEmail') ) %] + [% IF ( Koha.Preference('ExtendedPatronAttributes') && patron_attribute_classes.size && action != 'new' ) %] [% FOREACH pa_class IN patron_attribute_classes %] [% IF pa_class.class %]
    -- 2.39.5