From 32e27ff22c1a74f61b9e703b4b354bf13bfc2c95 Mon Sep 17 00:00:00 2001
From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Date: Wed, 3 Feb 2021 10:03:31 +0000
Subject: [PATCH] Bug 27600: Remove password check from SIP2 `renew_all`

This patch removes the password check code from the renew_all method for
SIP2. This is required, as many units send an empty AD field in the SIP
message which can cause the transaction to fail.. but the authentication
should have already taken place earlier in the session.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
---
 C4/SIP/ILS.pm | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/C4/SIP/ILS.pm b/C4/SIP/ILS.pm
index 3e5b6a4824..a80052e033 100644
--- a/C4/SIP/ILS.pm
+++ b/C4/SIP/ILS.pm
@@ -511,15 +511,12 @@ sub renew_all {
         siplog("LOG_DEBUG", "ILS::renew_all: Invalid patron id: '%s'", $patron_id);
     }
 
-    if (!defined($patron)) {
+    if (!$patron) {
 		$trans->screen_msg("Invalid patron barcode.");
 		return $trans;
     } elsif (!$patron->renew_ok) {
 		$trans->screen_msg("Renewals not allowed.");
 		return $trans;
-    } elsif (defined($patron_pwd) && !$patron->check_password($patron_pwd)) {
-		$trans->screen_msg("Invalid patron password.");
-		return $trans;
     }
 
 	$trans->do_renew_all;
-- 
2.39.5