]> git.koha-community.org Git - koha.git/commit
Bug 34552: Don't exclude payments with no status
authorNick Clemens <nick@bywatersolutions.com>
Fri, 25 Aug 2023 15:51:12 +0000 (15:51 +0000)
committerMatt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Thu, 28 Sep 2023 08:14:01 +0000 (08:14 +0000)
commit9d48eccea9ec2c2639e64adf2c44476a2ec7a844
tree8ee279d4182822426883432af0cafa9217c6fcb6
parent3d7eb66e88ea013a8384b2b587cb5c2335fc2dd1
Bug 34552: Don't exclude payments with no status

Bug 29664 removed payments with a void status, however, the query also
removed any payments with no status set

Test Plan:
1 - Set up your cash registers and enable POS and add a debit type that is able to be sold
2 - Take 2 payments via POS
3 - Void one payment
4 - Go to Reports->Statistics wizards->Cash register
4) Verify neither shows for the "All payments to the library" and
   "Payment" transaction type filters
5) Apply this patch
6) Restart all the things!
7) Verify the non-voided fee shows for the "All payments to the library" and
   "Payment" transaction type filters and the voided fee does not

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 6ee6bea6bfee301146dc2f631480b227d237e43a)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 7d977be3e9431ee7f7e7c58a2889189ef648966b)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
reports/cash_register_stats.pl