]> git.koha-community.org Git - koha.git/commit
Bug 30667: Holds reminder cronjob (holds_reminder.pl) never uses default letter template
authorKyle Hall <kyle@bywatersolutions.com>
Tue, 3 May 2022 10:53:43 +0000 (06:53 -0400)
committerArthur Suzuki <arthur.suzuki@biblibre.com>
Sun, 21 Aug 2022 08:42:50 +0000 (10:42 +0200)
commitb4c4902657c88683e531135a5615ad16959edde4
tree05c47eb0d313e30ebf360c69196245ecbe759d01
parenta94dfeae57de81ae50ea52b358e106c5c57a9269
Bug 30667: Holds reminder cronjob (holds_reminder.pl) never uses default letter template

Bug 28514 changed the way holds_reminder.pl searches for templates, using a direct search for letters,
but should be using find_effective_template instead. Now, if a branch specific template does not exist,
it will skip that branch.

Test Plan:
1) Ensure you only have the default HOLD_REMINDER template
2) Become the koha user using koha-shell
3) Run misc/cronjobs/holds/holds_reminder.pl --days 7 -v
4) Note that the script skips every branch
5) Apply this patch
6) Run the command in step 3 again
7) Note the script doesn't skip over any branches

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit a7e7939748ef9c3f8df8aefb20f5ca9169d4575d)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
misc/cronjobs/holds/holds_reminder.pl