]> git.koha-community.org Git - koha.git/commit
Bug 21035: Handle new lines when running reports
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 4 Jul 2018 18:05:25 +0000 (15:05 -0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 21 Sep 2018 12:10:59 +0000 (14:10 +0200)
commitfc0841f55432464c6e73eb485b2babd0f7598133
tree116abebe9084cd47984c07d2fc9d8c732028fea5
parent68828e1a5351a2f2f9cbf8e9d98544b2647af447
Bug 21035: Handle new lines when running reports

See https://metacpan.org/pod/Text::CSV_XS#Embedded-newlines

Test plan:

1) Choose two items, say barcode '123' and '456'
2) Change the public note on 123 to read

Line1
Line2

(I.e. type 'Line1', then press Enter, type 'Line2' and click update).
3) Change the public note on 456 to read

Public note has one and only one line.

Click update.
4) Create a report with the followng query:

select barcode, itemnotes from items where barcode in ( '123', '456' )

Let's say that this is report number 10.

5) run ./misc/cronjobs/runreport.pl --format=csv REPORT_ID:

=> You should see both lines

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Followed the test plan and it works.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit f16fb888f132703063f0591e329d72d065f4b1d9)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 4fd18a7df711f5a59f459234ec186b175ee05eb6)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
misc/cronjobs/runreport.pl