From 2c1a83fd58f7e293764a2c282160122c245af816 Mon Sep 17 00:00:00 2001
From: Didier Gautheron <didier.gautheron@biblibre.com>
Date: Wed, 15 Sep 2021 07:32:34 +0200
Subject: [PATCH] Bug 29025: Don't prefill userid and password in user creation
 form

Recent Firefox versions try to prefill userid and password with
logged in user credentials.

To test
1 - Log in staff as user foo password bar
2 - Save user and password in Firefox
3 - Log out
4 - Log in again, log in pop-up must be pre-filled
5 - Open Create a new patron form
6 - At least password field is pre-filled with logged in user's credentials
7 - Apply patch
8 - Redo 4 and 5
9 - Userid and password fields aren't prefilled

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 89e2aa5a9bf5144672f38214869a8161561d410f)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 .../prog/en/modules/members/memberentrygen.tt             | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
index 643d4b9a46..cd3b9eabbe 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
@@ -1108,9 +1108,9 @@ legend:hover {
                                                             [% END %]
                                                         [% ELSE %]
                                                             [% IF ( opduplicate ) %]
-                                                                <input type="password" id="password" name="password" size="20" />
+                                                                <input type="password" id="password" name="password" size="20" autocomplete="new-password" />
                                                             [% ELSE %]
-                                                                <input type="password" id="password" name="password" size="20" value="[% password | html %]" />
+                                                                <input type="password" id="password" name="password" size="20" autocomplete="new-password" value="[% password | html %]" />
                                                             [% END %]
                                                         [% END # /IF ( NoUpdateLogin ) %]
                                                     [% ELSE # IF ( opadd ) %]
@@ -1120,7 +1120,7 @@ legend:hover {
                                                                 <input type="password" id="password" name="password" size="20"  disabled="disabled" value="****" />
                                                             [% ELSE %]
                                                                 [% IF ( opduplicate ) %]
-                                                                    <input type="password" id="password" name="password" size="20" />
+                                                                    <input type="password" id="password" name="password" autocomplete="new-password" size="20" />
                                                                 [% ELSE %]
                                                                     <input type="password" id="password" name="password" size="20" value="****" />
                                                                 [% END %]
@@ -1129,7 +1129,7 @@ legend:hover {
                                                             [% IF ( NoUpdateLogin ) %]
                                                                 <input type="password" id="password" name="password" size="20"  disabled="disabled" value="" />
                                                             [% ELSE %]
-                                                                <input type="password" id="password" name="password" size="20" value="" />
+                                                                <input type="password" id="password" name="password" size="20" autocomplete="new-password" value="" />
                                                             [% END %]
                                                         [% END # /IF ( password ) %]
                                                     [% END # /IF ( opadd )  %]
-- 
2.39.5