]> git.koha-community.org Git - koha.git/commit
Bug 34945: Remove the use of event attributes from OPAC clubs tab
authorOwen Leonard <oleonard@myacpl.org>
Thu, 28 Sep 2023 11:30:35 +0000 (11:30 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Wed, 4 Oct 2023 13:44:03 +0000 (09:44 -0400)
commita3849909a98f286ffedead029aff5fc2b16a6c76
tree575eecf3fc1be4edef1ec4876f6f0774bd8cdbbd
parent075876fe0530258eaa22c0a24e7f472896232d9d
Bug 34945: Remove the use of event attributes from OPAC clubs tab

This patch removes the use of event attributes (onclick) from the
template for the clubs tab shown in the OPAC to a logged-in user.
These events are defined now along with the other in-page JS.

The patch also makes some general improvements to the template for
consistency:

- Adding Bootstrap color classes to the "Enroll" and "Cancel enrollment"
  buttons.
- Enhancing the responsive configuration to the DataTable.

To test you should have a few patron clubs defined (Tools -> Patron
clubs).

- Apply the patch and log in to the OPAC.
- On the user summary page, click the "Clubs" tab.
- The "Enroll" and "Cancel enrollment" buttons should look correct and
  work as expected:
  - Click the "Enroll" button.
    - On the enrollment confirmation view, test both the "Finish
      enrollment" button and the "Cancel" link.
  - Test "Cancel enrollment" button.
- Test the responsive behavior of the page to confirm that it adjusts
  well to narrow browser widths.

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/clubs-tab.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt