From 2ad424704fc2ec7c6978fb24c1a292c52d188659 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Mon, 9 Nov 2020 11:20:43 +0100
Subject: [PATCH] Bug 26971: Remove obsolete test file translatable-templates.t

After bug 25067 we found that this test file is failing with

 #   Failed test 'opac_bootstrap templates are translatable'
 #   at xt/author/translatable-templates.t line 91.
 # Unknown action specified.

The original patches forgot to update this file.
However when we tried to adjust it, we found that those tests are never working.

Tried on 18.11.00 with a very ugly modified intranet-main.tt, the test was still passing.

No idea how we can make it display warnings and so hard to fix the expected behaviour.

I decided to remove it for now and see later if we need an updated test for the translate script.

See also 25067 comment 84

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 xt/author/translatable-templates.t | 94 ------------------------------
 1 file changed, 94 deletions(-)
 delete mode 100755 xt/author/translatable-templates.t

diff --git a/xt/author/translatable-templates.t b/xt/author/translatable-templates.t
deleted file mode 100755
index bc4cd1501f..0000000000
--- a/xt/author/translatable-templates.t
+++ /dev/null
@@ -1,94 +0,0 @@
-#!/usr/bin/perl
-
-# This file is part of Koha.
-#
-# Koha is free software; you can redistribute it and/or modify it
-# under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 3 of the License, or
-# (at your option) any later version.
-#
-# Koha is distributed in the hope that it will be useful, but
-# WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Koha; if not, see <http://www.gnu.org/licenses>.
-
-use Modern::Perl;
-=head2 translate-templates.t
-
-This test verifies that all staff and OPAC template
-files can be processed by the string extractor
-without error; such errors usually indicate a 
-construct that the extractor cannot parse.
-
-=cut
-
-use Test::More;
-use File::Temp qw/tempdir/;
-use IPC::Open3;
-use File::Spec;
-use Symbol qw(gensym);
-use FindBin qw($Bin);
-use Cwd qw(abs_path);
-use utf8;
-
-my $po_dir = tempdir(CLEANUP => 1);
-
-# Find OPAC themes
-my $opac_dir  = 'koha-tmpl/opac-tmpl';
-opendir ( my $dh, $opac_dir ) or die "can't opendir $opac_dir: $!";
-my @opac_themes = grep { not /^\.|lib|js|xslt/ } readdir($dh);
-close $dh;
-
-# Find STAFF themes
-my $staff_dir = 'koha-tmpl/intranet-tmpl';
-opendir ( $dh, $staff_dir ) or die "can't opendir $staff_dir: $!";
-my @staff_themes = grep { not /^\.|lib|js/ } readdir($dh);
-close $dh;
-
-my $misc_translator_dir = abs_path("$Bin/../../misc/translator");
-
-chdir $misc_translator_dir; # for now, tmpl_process3.pl works only if run from its directory
-
-# Check translatable of OPAC themes
-for my $theme ( @opac_themes ) {
-    test_string_extraction("opac_$theme",     "../../koha-tmpl/opac-tmpl/$theme/en",     $po_dir);
-}
-
-# Check translatable of STAFF themes
-for my $theme ( @staff_themes ) {
-    test_string_extraction("staff_$theme",     "../../koha-tmpl/intranet-tmpl/$theme/en",     $po_dir);
-}
-
-sub test_string_extraction {
-    my $module       = shift;
-    my $template_dir = shift;
-    my $po_dir       = shift;
-
-    my $command = "PERL5LIB=\$PERL5LIB:$misc_translator_dir ./tmpl_process3.pl create -i $template_dir -s $po_dir/$module.po -r --pedantic-warnings";
-   
-    open (NULL, ">", File::Spec->devnull); ## no critic (BarewordFileHandles)
-    print NULL "foo"; # avoid warning;
-    my $pid = open3(gensym, ">&NULL", \*PH, $command); 
-    my @warnings;
-    while (<PH>) {
-        # ignore some noise on STDERR
-        # the output of msmerge, that consist in .... followed by a "done" (localized), followed by a .
-        # The "done" localized can include diacritics, so ignoring the whole word
-        # FIXME PP: the flow is not correct UTF8, testing \p{IsLetter} does not work, but I think this regexp will do the job
-        next if (/^\.+ .*\.$/);
-        # other Koha-specific catses that should not worry us
-        next if /^Warning: Can't determine original templates' charset/;
-        next if /^Warning: Charset Out defaulting to/;
-        next if /^Removing empty file /;
-        next if /^I UTF-8 O UTF-8 at /;
-        push @warnings, $_;
-    }
-    waitpid($pid, 0);
-
-    ok($#warnings == -1, "$module templates are translatable") or diag join("\n", @warnings, '');
-}
-
-done_testing();
-- 
2.39.5