From 68afa5ac893be4c1baa7cf615620cb71787c2908 Mon Sep 17 00:00:00 2001 From: David Nind Date: Fri, 16 Aug 2024 22:05:49 +0000 Subject: [PATCH] Bug 37662: Improve library information text consistency This improves the consistency of the text between the staff interface library information listing page, and the add, view, and modify library pages. It also improves the text for some field hints. Test plan: 1. Go to Koha administration > Basic parameters > Libraries. 2. Note these inconsistencies: 2.1 Library hours - the text if no hours are set: - For the table, the text is "Library hours not set" - For the view, add, and modify library pages the text is "No opening hours have been set." 2.2 The column and field names for library hours: - For the table, the column name in the list of libraries is "Library hours". - For the view, add, and modify library pages the field label is "Opening hours". 2.3 For the "MARC organization code" field, there is no colon (:) on the view, add, and modify library pages. 2.4 For the "OPAC info" field name, "info" is not spelt in full. 2.5 The hints for the Reply-To and Return-Path fields use this format "Default: system preference" pattern, but the MARC organization code field doesn't. 3. Leave tabs open for the library listing, view, and modify library pages. 4. Apply the patch, then duplicate and refresh the tabs for the library listing, view, and modify library pages (so you can compare the differences). 5. Note that the inconsistencies in step 2 are now fixed. 6. Note that the hint text for these fields is changed: 6.1 IP field: active voice 6.2 MARC organization code: follows the pattern used for the Reply-To and Return-Path fields. 6.3 Public: 'yes' to 'Yes' 7. Sign off D: Signed-off-by: David Nind Signed-off-by: Olivier Vezina Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer --- .../prog/en/modules/admin/branches.tt | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt index 363a8b57da..35c27cac57 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt @@ -241,7 +241,7 @@
    • -
  • +
  • [% IF OpacLibraryInfo %]
    [% OpacLibraryInfo.content | $raw %]
    Edit HTML content
    @@ -252,19 +252,19 @@
  • -
    Can be entered as a single IP, or a subnet such as 192.168.1.*
    +
    Enter as a single IP address, or a subnet such as 192.168.1.*
  • - +
    [% IF ( CAN_user_parameters_manage_sysprefs ) %] [% pref_MARCOrgCode_link = BLOCK %]MARCOrgCode[% END %] - If not filled in defaults to system preference [% pref_MARCOrgCode_link | $raw | $KohaSpan %]. + Default: [% pref_MARCOrgCode_link | $raw | $KohaSpan %] system preference. [% ELSE %] - If not filled in defaults to system preference MARCOrgCode. + Default: MARCOrgCode system preference. [% END %] - You can obtain your code from Library of Congress. + Obtain a library code from the Library of Congress.
    • @@ -289,10 +289,10 @@ [% END %] -
    Set to 'yes' to show this library as a search option and on the libraries page in the OPAC.
    +
    Set to 'Yes' to show this library as a search option and on the libraries page in the OPAC.
  • - + @@ -532,7 +532,7 @@ [% library.branchip | html %]
  • - MARC organization code + MARC organization code: [% library.marcorgcode | html %]
  • @@ -556,7 +556,7 @@ [% END %]
  • - Opening hours: + Library hours: [% SET CalendarFirstDayOfWeek = Koha.Preference("CalendarFirstDayOfWeek") %] [% SET set_hours = 0 %] [% IF library.library_hours.count > 0 %] @@ -595,7 +595,7 @@
    • [% ELSE %] - No opening hours have been set. + Library hours not set [% END %]
    • -- 2.39.5