From 798f176f2908ad7b53b6da6341c512a4398d6b86 Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Fri, 13 Mar 2020 17:40:38 +0000 Subject: [PATCH] Bug 24848: Improve manual links for the label creator Some of the manual links in the label creator tool were not working correctly or pointing to the wrong pages. A problem is the label-manage.pl file. This can show different data depending on an added parameter. Example: /cgi-bin/koha/labels/label-manage.pl?label_element=template But it appears that parameters will be ignored when creating links to the manual. So this patch links to the beginning of the label creator section in the manual for now. To test: - Go to the lable creator - Try the various pages of the tool - Note: All 'New ...' links should point to the correct section in the manual (batches, templates, ...) Except: Barcode range. This feature is new and not yet documented in the manual. Link goes to label creator section. - Note: All 'Manage ...' links should point to the beginning of the 'label creator' section in the manual Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit cda91af335a163b9e1d12c2aac57ec46b24ddea4) Signed-off-by: Lucas Gass --- Koha/Manual.pm | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/Koha/Manual.pm b/Koha/Manual.pm index d46523d495..c86f962808 100644 --- a/Koha/Manual.pm +++ b/Koha/Manual.pm @@ -132,15 +132,13 @@ our $mapping = { 'course_reserves/course-details' => '/course_reserves.html', 'course_reserves/course-reserves' => '/course_reserves.html', 'course_reserves/course' => '/course_reserves.html#adding-courses', - 'labels/label-edit-batch' => '/tools.html#batches', - 'labels/label-edit-layout' => '/tools.html#layouts', - 'labels/label-edit-profile' => '/tools.html#profiles', - 'labels/label-edit-template' => '/tools.html#templates', - 'labels/label-home' => '/tools.html#label-creator', - 'labels/label-manage' => '/tools.html#layouts', - 'labels/label-manage' => '/tools.html#templates', - 'labels/label-manage' => '/tools.html#profiles', - 'labels/label-manage' => '/tools.html#batches', + 'labels/label-edit-batch' => '/tools.html#label-batches-label', + 'labels/label-edit-layout' => '/tools.html#label-layouts-label', + 'labels/label-edit-profile' => '/tools.html#label-profiles-label', + 'labels/label-edit-range' => '/tools.html#label-creator-label', #FIXME Add when documented + 'labels/label-edit-template' => '/tools.html#label-templates-label', + 'labels/label-home' => '/tools.html#label-creator-label', + 'labels/label-manage' => '/tools.html#label-creator-label', 'labels/spinelabel-home' => '/tools.html#quick-spine-label-creator', 'mainpage' => '/', 'members/apikeys' => '/webservices.html#api-key-management-interface-for-patrons', -- 2.39.5