]> git.koha-community.org Git - koha.git/commit
Bug 36575: Return correct patron when there is a shared userid / cardnumber
authorNick Clemens <nick@bywatersolutions.com>
Thu, 11 Apr 2024 09:39:03 +0000 (09:39 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Mon, 3 Jun 2024 15:10:13 +0000 (15:10 +0000)
commit5bd4dbafea8c05efb8e3333b569fff81b8956e7e
treefa05cf3ff8021ae19298d343b4031b01384d3584
parent37bc325203b5e5b548a5d62c2a852f587c64a647
Bug 36575: Return correct patron when there is a shared userid / cardnumber

This patch moves some patron fetching code in C4/Auth to use to patron returned from the validation
methods and only try to fetch the patron (to check if locked, update attempts, etc) if we didn't authenticate

To test:
1 - Set a user to have userid = BANANA password = Password1
2 - Set a user to have cardnumber = BANANA password = Password2
3 - Hit the patron authentication API:
    http://localhost:8080/api/v1/auth/password/validation
    with data:
    { "identifier": "BANANA", "password":"Password1" }
    and:
    { "identifier": "BANANA", "password":"Password2" }
4 - Note you receive the same response for both
5 - Apply patch, restart all
6 - Repeat the API and confirm you get the correct patron for the password submitted

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
C4/Auth.pm
t/db_dependent/Auth.t
t/db_dependent/api/v1/password_validation.t