]> git.koha-community.org Git - koha.git/commit
Bug 26231: Remove incorrect use of AddAuthority() when 001 present
authorDavid Cook <dcook@prosentient.com.au>
Tue, 18 Aug 2020 02:20:32 +0000 (12:20 +1000)
committerVictor Grousset/tuxayo <victor@tuxayo.net>
Tue, 20 Oct 2020 21:08:14 +0000 (23:08 +0200)
commita2cbbb4e1d091d41b75700f153976e470b72e18d
tree6bb66e6f1a49f941156b5c989e768518bb5068b6
parent28b8065003d6d6cc3fb4c98b32b0bb6e45ac78fa
Bug 26231: Remove incorrect use of AddAuthority() when 001 present

This patch removes the use of AddAuthority with a non-empty
authid argument, since that triggers an update rather than an insert.

In practice, the update also fails, but the error isn't raised,
as the database connection doesn't have RaiseError set.

Test plan:
1) Do not apply patch
2) Try to bulkmarcimport an authority file with a 001
3) Observe that the script reports success but no authority is added
4) Apply the path
5) Try to bulkmarcimport an authority file with a 001
6) Observe that the script reports success and the authority is added

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 9622561636387ced932cc31e285d13cdba607c47)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 276602aadbdb27cbec780c9564b93ccd0c1961b6)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
(cherry picked from commit be9eeef3c9cc746e25a44b362d4d78a3739e4fb5)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
misc/migration_tools/bulkmarcimport.pl