]> git.koha-community.org Git - koha.git/commit
Bug 16200: Make 'Hold waiting too long' translatable and give it an unique accounttype
authorLari Taskula <larit@student.uef.fi>
Tue, 17 May 2016 11:33:57 +0000 (14:33 +0300)
committerJulian Maurice <julian.maurice@biblibre.com>
Thu, 16 Jun 2016 07:22:26 +0000 (09:22 +0200)
commit17514959011434f9d868b8f7f553104228718789
tree4f320f4b62facca1cc35d60318b9678295eb3714
parent8474209c40f3364b2a85bec3f1e4ed6ece9c4bba
Bug 16200: Make 'Hold waiting too long' translatable and give it an unique accounttype

Holds that have expired have been untranslatable in Patron's Fines-tab. Also, they are
mixed with other type of fines with accounttype "F". This patch gives expired holds an
own accounttype "HE" (Hold Expired) and modifies the boraccount to recognize this new
accounttype in order to make it translatable.

To test:
1. Make a hold and let it expire
2. Go to Patron's Fines tab
3. Change Koha's language to some other than English
4. Observe that there is a "Hold waiting too long" fine described in English
5. Apply patch
6. Make another hold and let it expire
7. Update translations
8. Find "Hold waiting too long" from your .po file
9. Translate it and install translations
10. Go back to Fines tab and observe that the new expired hold is translated

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 7163fcfeea382e1e042a47a76d384155e8c69bc0)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
(cherry picked from commit 326616d2bce77b245e0d38eb3df659e821130645)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
C4/Reserves.pm
koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt