]> git.koha-community.org Git - koha.git/commit
Bug 15823: Can still access patron discharge slip without having the syspref on
authorAleisha <aleishaamohia@hotmail.com>
Tue, 23 Feb 2016 04:06:30 +0000 (04:06 +0000)
committerJulian Maurice <julian.maurice@biblibre.com>
Mon, 16 May 2016 07:22:05 +0000 (09:22 +0200)
commit8e91b20fa714649ebd8b64fe4e1074a1e5791000
treed2158bf4db7a21f2008640ac96b79104d8a726d8
parent9f1e23735f46a8b014d4a8983796f1b8b37cc9b4
Bug 15823: Can still access patron discharge slip without having the syspref on

EDIT: Fix for OPAC side
EDIT: Comment 10
EDIT: Merge conflicts

To test:
1) Ensure syspref useDischarge is disabled
2) Go to /cgi-bin/koha/members/discharge.pl?borrowernumber=X&discharge=1
3) Validate that you are still able to generate a discharge slip for this patron
4) Apply patch and refresh page
5) Confirm that you are redirected to the circulation.pl page for the user and that an error message is there.
OPAC SIDE
6) Go to the OPAC
7) Go to /cgi-bin/koha/opac-discharge.pl
8) Confirm you get a message saying discharges are disabled
9) Go to /cgi-bin/koha/opac-discharge.pl?op=request
10) Confirm you see same message

Sponsored-by: Catalyst IT
Followed test plan, works as expected (both staff client and OPAC).
Re-tested, works OK.
Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 853d3cfe4d76d6f847e4f30dca4d50d278951fd0)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
circ/circulation.pl
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt
members/discharge.pl