]> git.koha-community.org Git - koha.git/commit
Bug 12876 - Reserve in waiting/transfer status may be cancelled by user
authorRafal Kopaczka <rkk0@poczta.onet.pl>
Fri, 5 Sep 2014 12:50:15 +0000 (14:50 +0200)
committerGalen Charlton <gmc@esilibrary.com>
Wed, 1 Oct 2014 21:43:27 +0000 (21:43 +0000)
commitc0ab862f4a902ce261b9b8870c169f6fe27711e1
treed10080485c4ae02da2b16bf303b5a7e50af67ade
parent60875757c761a9ad59734e968cf34a831c65e9a6
Bug 12876 - Reserve in waiting/transfer status may be cancelled by user

User may cancel his own reservation at waiting or in transit status
through calling opac-modrequest.pl. Cancel button is disabled in
interface but possibility to cancel should be checked also in
opac-moderequest.pl, before calling CancelReserve().
Similar situation is with opac-modrequest-suspend.pl

This patch provides new soubroutine to chceck if user can cancel given
reserve. It's possible only when he's owner of hold and hold isn't in
transfer or waiting status.

Additionaly there are new test for this function in Reserves.t

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests, QA script and new tests.
Works as described, tested with:
.../cgi-bin/koha/opac-modrequest.pl?reserve_id=XXX

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Conflicts:
t/db_dependent/Reserves.t

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
C4/Reserves.pm
opac/opac-modrequest-suspend.pl
opac/opac-modrequest.pl
t/db_dependent/Reserves.t