]> git.koha-community.org Git - koha.git/commit
Bug 18321: Correctly calculate switch_onsite_checkout
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 31 Mar 2017 03:24:09 +0000 (00:24 -0300)
committerKatrin Fischer <katrin.fischer.83@web.de>
Fri, 21 Apr 2017 22:08:40 +0000 (00:08 +0200)
commit77aaf0dabfc19fcc6569f1b730154823ada94b5f
tree3870de15c204d66540def9ff06d7dae5ed132688
parent302b66badafe5112f738ffd35f809b4b62e8fba5
Bug 18321: Correctly calculate switch_onsite_checkout

Silly error here, the $switch_onsite_checkout is not correctly
calculated, it should not only be set to the value of the syspref, but
meet all the conditions.

Test plan:
Set a circ rule with number of on-site checkout = 2 and number of
checkouts = 2.
Switch on both ConsiderOnSiteCheckoutsAsNormalCheckouts and SwitchOnSiteCheckouts

Do a regular checkout
Do another regular checkout
At this point you have reach the maximum number of checkouts allowed.
Not try another one.
=> Without this patch you will not get the warning
=> With this patch you will see it

Followed test plan, works as expected.
Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit f04c5d5a2c549bed54036b726965ccda083def7b)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
C4/Circulation.pm