]> git.koha-community.org Git - koha.git/commit
Bug 23403: Remove cardnumber from SIP
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 21 Nov 2019 17:39:15 +0000 (18:39 +0100)
committerVictor Grousset/tuxayo <victor@tuxayo.net>
Thu, 11 Jun 2020 13:11:36 +0000 (15:11 +0200)
commitdbc740a62aca9bea76400a0147ad8152864e8ad4
treee3f50149aa2ff7e09810f83984e94dc5ebebefa1
parentba884d407a4b7ac858b68b4958e3f234e1b616da
Bug 23403: Remove cardnumber from SIP

== Test plan ==
1 - Have two patrons with userids and no cardnumber
2 - Note which of these has the higher borrower number
3 - Use the SIP cli emulator to connect and checkout a book to the patron with higher borrowernumber
      See example after
4 - Note the book may checkout to the wrong patron!
5 - Apply patch
6 - Checkout to both patrons via sip
7 - The patrons get the correct checkouts

=== SIP CLI emulator ===
./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 \
-l CPL --patron 23529001000463 -m checkout --item 39999000001259

translation: via the koha user term1, checkout item 39999000001259 to
patron 23529001000463

Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
(cherry picked from commit 7e4296c4194afaa722a20b114cf928e2f17d7ad0)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
C4/SIP/ILS/Item.pm
C4/SIP/ILS/Transaction/Checkout.pm
C4/SIP/ILS/Transaction/Hold.pm
C4/SIP/ILS/Transaction/Renew.pm