]> git.koha-community.org Git - koha.git/commit
Bug 8604: Patron cards made for patrons which don't have patron images use preceding...
authorChris Nighswonger <cnighswonger@foundations.edu>
Wed, 4 Jul 2018 15:23:11 +0000 (11:23 -0400)
committerFridolin Somers <fridolin.somers@biblibre.com>
Tue, 28 Aug 2018 13:13:11 +0000 (15:13 +0200)
commit297219f0dc137d0ee4eb343902be29e793a1d60c
treee20c2a3d7a765da3d3f00398e184f899ef7d5299
parent211a188494a40f0ef6cc1f3b993d0171602eeefa
Bug 8604: Patron cards made for patrons which don't have patron images use preceding card's image

This patch corrects referential problems which caused the script to
"re-use" images as well as other sorts of bad image behaviour.

To test:

1. Ensure that you can reproduce the original bug or some variation thereof
using the steps described in either of these two comments:

    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604#c0

    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604#c6

    NOTE: This is not an easy bug to reproduce.

2. Once you can reproduce the bug, apply this patch and follow the same steps
used to reproduce the bug.

3. Observe that the symptoms are corrected.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Reproduced the bug and resolved it with this patch.
Code is hard to read; exact cause of the problem was not fully uncovered.

Fixed spelling 'Destory' => 'Destroy'

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit b5e60f15478a998f945ebc59b2c13ce9d37b8818)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 97825af008ba57f7d7229ddb6ce9318e67e22e18)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
patroncards/create-pdf.pl