From f1ecd4eef11cfa5d807ec66c63d963a56367e571 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 13 Feb 2024 08:32:50 +0100
Subject: [PATCH] Bug 34478: guided_reports - run is stateless

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 .../prog/en/modules/reports/guided_reports_start.tt      | 9 ++++-----
 reports/guided_reports.pl                                | 4 ++--
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
index b3d4f9e0e7..193c7884fe 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
@@ -849,9 +849,8 @@
                             <a href="/cgi-bin/koha/reports/guided_reports.pl?op=edit_formid=[% id | uri %]" class="btn btn-primary">Edit SQL</a>
                         </fieldset>
                     [% ELSE #  IF ( auth_val_error ) %]
-                        <form method="post" action='/cgi-bin/koha/reports/guided_reports.pl'>
+                        <form method="get" action='/cgi-bin/koha/reports/guided_reports.pl'>
                             <input type='hidden' name='id' value="[% id | html %]" />
-                            <input type='hidden' name='op' value='cud-run' />
                             <h1>Enter parameters for report [% name | html %]:</h1>
                             [% IF ( notes ) %]
                                 <p>[% notes | html %]</p>
@@ -891,7 +890,7 @@
                                 </ol>
                             </fieldset> <!-- /.rows -->
                             <fieldset class="action">
-                                <input type="hidden" name="op" value="cud-run" />
+                                <input type="hidden" name="op" value="run" />
                                 <button type="submit" class="btn btn-primary">Run the report</button>
                             </fieldset>
                         </form>
@@ -1026,8 +1025,8 @@
                                         [%- END -%]
                                 [% END %]
 
-                                <form action="/cgi-bin/koha/reports/guided_reports.pl" method="post" id="limitselect">
-                                    <input type="hidden" name="op" value="cud-run"/>
+                                <form action="/cgi-bin/koha/reports/guided_reports.pl" method="get" id="limitselect">
+                                    <input type="hidden" name="op" value="run"/>
                                     <input type="hidden" name="reports" value="[% id | html %]"/>
                                     [% FOREACH p IN sql_params %]
                                         <input type="hidden" name="sql_params" value="[% p | html %]"/>
diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl
index a6b9bcf248..d57e7db141 100755
--- a/reports/guided_reports.pl
+++ b/reports/guided_reports.pl
@@ -246,7 +246,7 @@ elsif ( $op eq 'cud-update_sql' || $op eq 'cud-update_and_run_sql' ){
             );
         }
         if ( $op eq 'cud-update_and_run_sql' ) {
-            $op = 'cud-run';
+            $op = 'run';
         }
     }
 }
@@ -756,7 +756,7 @@ elsif ( $op eq 'add_form_sql' || $op eq 'duplicate' ) {
     );
 }
 
-if ($op eq 'cud-run'){
+if ($op eq 'run'){
     # execute a saved report
     my $limit           = $input->param('limit') || 20;
     my $offset          = 0;
-- 
2.39.5