]> git.koha-community.org Git - koha.git/commit
Bug 21299: Introduce localReferer in [opac-]changelanguage.pl
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Mon, 30 Jul 2018 10:57:58 +0000 (12:57 +0200)
committerNick Clemens <nick@bywatersolutions.com>
Wed, 7 Nov 2018 21:52:17 +0000 (21:52 +0000)
commit07d5f76225a3acd905fecf53ccdc4f52474d7ffc
treeb0b2be17e58695614fc56648a1f5494fa1194565
parentdb539f4dc0b5f7ceb0726c97c95310d5b853de15
Bug 21299: Introduce localReferer in [opac-]changelanguage.pl

With the work from the former patch, we now have a nice and easy replace..

NOTE: The additional logic in opac-changelanguage.pl is now also applied
to the intranet counterpart (changelanguage.pl). This effectively makes
changelanguage.pl no longer refer to external URLs (as the opac already
did by testing the referer). Might be just theoretical, but consistent.

Test plan:
Test changing language from various OPAC and staff locations.
Include language=[some_language] in the URL before changing language.
[Bonus] Test calling changelanguage.pl from another server. You should no
longer be referred back to the calling server. (See below.)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Added link <a href="[mystaffserver]/cgi-bin/koha/changelanguage.pl?language=en">link</a> somewhere on external server.
Verified that without this patch, it hits the staff server and refers back to the caller. But with this patch, it refers to staff homepage.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
changelanguage.pl
opac/opac-changelanguage.pl