]> git.koha-community.org Git - koha.git/commit
Bug 13423: Remove unused serials-recieve
authorBernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Sat, 25 Apr 2015 12:01:44 +0000 (09:01 -0300)
committerChris Cormack <chrisc@catalyst.net.nz>
Sun, 17 May 2015 23:13:09 +0000 (11:13 +1200)
commit7fdf0545dce3309486a2099269040938747dfb28
treedf3e9fb01447543ed3d1d4e0808055d576c1c417
parent1da4936e05101e323ffdd8f4c2fc49631bd471d0
Bug 13423: Remove unused serials-recieve

This patch removes two files, serials-recieve.pl and serial-recieve.tt
serials-recieve.pl is not called anyware
(it's recieve!)

Also removes the sub removeMissingIssue called only from serials-recieve.pl

git grep serials-recieve.pl .
C4/Serials.pm:called when a missing issue is found from the serials-recieve.pl file
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt:     <form method="post" name="f" action="serials-recieve.pl" onsubmit="return barcode_check()">
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt:     <form method="post" name="f2" action="serials-recieve.pl">
serials/serials-recieve.pl:serials-recieve.pl

Just a POD entry and self reference.

After removing of files

git grep removeMissingIssue .
C4/Serials.pm:      &check_routing &updateClaim &removeMissingIssue
C4/Serials.pm:=head2 removeMissingIssue
C4/Serials.pm:removeMissingIssue($subscriptionid)
C4/Serials.pm:sub removeMissingIssue {
t/db_dependent/Serials.t:is(C4::Serials::removeMissingIssue(), undef, 'test removing a missing issue');

Not used anymore

To test:
1) Apply the patch
2) Check serials workflow, no changes must be noted

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 65b7ad030cd5cd0e3148fbbd1496d31b5cf149f7)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Conflicts:
serials/serials-recieve.pl
C4/Serials.pm
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt [deleted file]
serials/serials-recieve.pl [deleted file]
t/db_dependent/Serials.t