Ryan Higgins [Mon, 2 Jun 2008 23:23:25 +0000 (18:23 -0500)]
Add MARC preview to cataloguing search, and add a link to add holdings. Once the edititems permission patch is accepted, this page should be updated to require edititems instead of editcatalogue.
Galen Charlton [Mon, 2 Jun 2008 14:05:04 +0000 (09:05 -0500)]
kohabug 2078 - send correct Content-type for search feeds
OPAC search RSS and ATOM feeds now have the correct
Content-type sent - "application/rss+xml" and "application/atom+xml",
respectively.
As part of this patch, added an optional fourth parameter
to C4::Output::output_html_with_http_headers to specify
the content type. If that parameter is now supplied, or if
the value of the parameter does not contain at least a "/",
the default type of "text/html" is returned.
Galen Charlton [Mon, 2 Jun 2008 02:43:31 +0000 (21:43 -0500)]
kohabug 2078 - fix feed validation errors
Fix several validation errors in RSS and Atom feeds
generated from the OPAC:
- add missing guid to RSS elements
- add missing feed ID and element ID to Atom elements
- reflect OPACBaseURL changes
- fix atom:link self links
- add HTML escaping to fields comming from bib record
- set default timestamp for Atom updated elements
Issues identified but not solved in this patch:
- setting Atom updated element for each bib (presumably
from biblio.timestamp)
- possible problems performing paging of Atom feed
Based on successful validation of feeds by feedvalidatory.org,
it is expected that feeds should now work in IE7 and IE6.
Galen Charlton [Mon, 2 Jun 2008 02:43:30 +0000 (21:43 -0500)]
calculate OPACBaseURL instead of using syspref
Calculate OPACBaseURL from the
CGI environment variables instead of using the
system preference. As a result of this patch,
it should be possible to change the hostname,
protocol, or port of the OPAC without having to
reset a system preference.
Also added a FIXME to opac/unapi - the URL of
the SRU/W server has no necessary relationship
to the URL of the OPAC.
Once this patch is confirmed, the syspref can
be removed.
Galen Charlton [Mon, 2 Jun 2008 02:43:28 +0000 (21:43 -0500)]
kohabug 2180 - improve display when fines block checkouts
If a patron's fine balance is over the limit set by the
noissuecharges syspref, checkouts are blocked. However,
this was not made very clear in the interface.
Improved the display by doing the following:
[1] If the fine balance is over the noissuecharges limit, use the "blocker"
styling (i.e., make all of the text red).
[2] Add wording to explicitly signal whether or not the fine balance is
blocking charges.
Documentation changes: new screenshots of blocked checkouts.
Ryan Higgins [Sun, 1 Jun 2008 17:25:17 +0000 (12:25 -0500)]
Independent-branchify MARC export. Add option to remove all holdings except your own, and force that behavior for independent branches. Also add accession date limit to export.
Owen Leonard [Sat, 31 May 2008 19:31:05 +0000 (14:31 -0500)]
Items from Bug 2167 ("URL handling in staff client inconsistent"): Removing display of URL from moredetail.pl. URLs are now displayed on detail.pl just as they are in the OPAC. Also removing display of biblio-level call number. Item level call number is displayed already.
Owen Leonard [Sat, 31 May 2008 19:08:57 +0000 (14:08 -0500)]
Fix for bug 2183, "Account tab needs spacing between description and stadard text" Please note that this is a band-aid for a larger issue, described in Bug 2188
Joe Atzberger [Sat, 31 May 2008 15:33:24 +0000 (10:33 -0500)]
Bugfix 1979 - display hold numbers. Note that hold priorities are still buggy.
But that is a separate bug from whether they display or not.
Also added basic error handling if biblionumber is not received, or
if biblionumber is bad, since that otherwise crashes the page.
Joe Atzberger [Sat, 31 May 2008 05:01:51 +0000 (00:01 -0500)]
Wrap up Tags integration - add sysprefs for new installs.
Note that when the user is not logged in, the Tags input box/button will not display.
The user will see a message telling them to log in to add tags. However, in order to
keep the results display clean, the message will display only once, utilizing the loop
context variable "__first__". Useful stuff!
I also threw OPACShelfBrowser sysprefs.sql, but it still needs added to updatedatabase.
Galen Charlton [Fri, 30 May 2008 19:37:33 +0000 (14:37 -0500)]
kohabug 2186 - improve display of empty import batches
[1] Display the "No records have been staged" message only
if no import batches exist.
[2] When displaying a batch that has no bibs in it, display
a "There are no records in this batch to import". Also,
do not display the "import record into catalogue" button
for an empty batch.
[3] Add CSS class "problem" to both messages.
Documentation changes: minor; only required if screenshots
exist of the manage staged MARC records page that has no
import batches on it.
Joshua Ferraro [Fri, 30 May 2008 18:56:17 +0000 (13:56 -0500)]
From HDL:
I agree that opac-suggestions.tmpl modification is Not required any longer.
But still, the modification in opac-suggestions.pl is really necessary.
If you donot do that, ppl are presented with ALL suggestions and not
their suggestions by default, which is not what My Suggestions suggests.
Joe Atzberger [Thu, 29 May 2008 18:15:23 +0000 (13:15 -0500)]
Repair Labels code to accomodate patroncards. Purged EXPR.
Major FIXME's still remain, like the use of GET instead of POST.
The code is also a bit too INCLUDE-happy to net good performance.
The entire mechanism of adding to a batch should probably be proper
AJAX instead of the GET-centric opener.location approach.
Joe Atzberger [Thu, 29 May 2008 13:59:25 +0000 (08:59 -0500)]
minor cleanup, remove $sth->finish's. No documentation impact.
For details: see http://search.cpan.org/~timb/DBI-1.14/DBI.pm
"There's no need to call finish if you're about to destroy or re-execute the statement handle."
In all these cases the sth is falling out of scope, about to be destroyed.
Galen Charlton [Wed, 28 May 2008 17:08:47 +0000 (12:08 -0500)]
kohabug 2164 - display of guarantor relationship
When editing a child or professional patron, display
the drop-down of relationship types only if at least
one relationship type is defined by the borrowerRelationship
syspref.
Joe Atzberger [Thu, 29 May 2008 01:31:28 +0000 (20:31 -0500)]
Tags AJAX integration on OPAC details page, so it behaves like results.
Also, prevent duplicate tags (same user, biblio and term). Strip
leading/trailing whitespace from term. Block whitespace terms.
The CSS for details could be enhanced to emphasize tagstatus more.
Joe Atzberger [Tue, 27 May 2008 23:06:01 +0000 (18:06 -0500)]
Fines repair. Make fines2.pl work, give feedback, improve comments and perldoc.
Remove $dbh->disconnect statements as counterproductive.
Prevent description field from begining with whitespace.
Added robust debug elements. Test script behavior with:
perl misc/cronjobs/fines2.pl -v
and:
mysql> select * from accountlines;
Joe Atzberger [Tue, 27 May 2008 23:05:57 +0000 (18:05 -0500)]
Commented out fixaccounts (not used anywhere). Also improved getnextacctno.
You can test getnextacctno like:
perl -e 'use C4::Accounts; print getnextacctno(33), "\n";'
where 33 is a borrowernumber out of the accountlines table. Get that number like:
mysql> select borrowernumber,accountno from accountlines LIMIT 100;
Note: we CANNOT rely on window.close in onSubmit or $().submit to close our popups.
On a relatively slow connection with a relatively large POST, commonly the close finishes
*before* the POST completes, as reported with our New Zealand clients. Despite success in
trivial cases, this should be obvious, since the event is necessarily before the submission.
It also assumes success and prevents any kind of error feedback. Other popups are likely
to exhibit this same defective behavior.
Some FIXME's outstanding: need to allow users to delete their own comments,
need to enforce and feedback on max comment length.
Joe Atzberger [Fri, 23 May 2008 07:40:49 +0000 (02:40 -0500)]
Unescape Comment, now that we trust Scrubber to block bad markup.
Obviously if we are going to allow good markup, we can't then escape it.
Documentation reference: allowed tags for comments are:
br b i em big small strong
Joe Atzberger [Wed, 21 May 2008 06:36:05 +0000 (01:36 -0500)]
Tags AJAX and JSON for OPAC side.
Note, all Tags js will live under KOHA.Tags namespace.
See opac-tags.pl perldoc for AJAX/JSON examples. The capability is already
there to be very web-servicey, even moreso than the current OPAC implementation
will utilize.
Joe Atzberger [Mon, 19 May 2008 21:23:35 +0000 (16:23 -0500)]
Add AJAX output sub, EXPORT_TAGS and enable loop_context_vars for HTML::Template::Pro.
The loop_context_vars will be very useful in display. They are:
__first__, __last__, __inner__, __odd__, __counter__.
Note: apparently __even__ does not exist, so instead use something like:
<!-- TMPL_UNLESS NAME="__odd__" -->
Frederic Demians [Tue, 20 May 2008 20:06:58 +0000 (22:06 +0200)]
Facets (current) translatable via template
This patch allows to translate facets label with standart
templates / PO files. Facets are still hard coded in Koha.pm.
Template wait those hard coded facets: Topics, Places, Titles,
Autors and Libraries.
projects / koha.git / log